Skip to content

feat(formatter_json): implement json-stringify variant#23192

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-10-feat_formatter_json_implement_json-stringify_variant
Jun 10, 2026
Merged

feat(formatter_json): implement json-stringify variant#23192
graphite-app[bot] merged 1 commit into
mainfrom
06-10-feat_formatter_json_implement_json-stringify_variant

Conversation

@leaysgur

@leaysgur leaysgur commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Implement last missing JSON family variant: json-stringify.

Format output matches prettier@3.8.4 for now, but we know prettier@3.9.0 will be coming soon.

https://github.com/prettier/prettier/blob/main/changelog_unreleased/json/18405.md

So I also implemented this and disabled under COMPAT_PRE_18405 flag.

@github-actions github-actions Bot added the A-formatter Area - Formatter label Jun 10, 2026
@leaysgur Graphite App

leaysgur commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 10, 2026
Merged
Merged
@leaysgur leaysgur force-pushed the 06-10-feat_formatter_json_implement_json-stringify_variant branch from 6ead07a to b456608 Compare June 10, 2026 04:52
@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing 06-10-feat_formatter_json_implement_json-stringify_variant (b456608) with main (bb0ed44)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 10, 2026
@graphite-app

graphite-app Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@leaysgur
feat(formatter_json): implement json-stringify variant (#23192)
8cc82c4 
Implement last missing JSON family variant: `json-stringify`.

Format output matches `prettier@3.8.4` for now, but we know `prettier@3.9.0` will be coming soon.

> https://github.com/prettier/prettier/blob/main/changelog_unreleased/json/18405.md

So I also implemented this and disabled under `COMPAT_PRE_18405` flag.
@graphite-app graphite-app Bot force-pushed the 06-10-feat_formatter_json_implement_json-stringify_variant branch from b456608 to 8cc82c4 Compare June 10, 2026 05:41
@graphite-app graphite-app Bot merged commit 8cc82c4 into main Jun 10, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 10, 2026
@graphite-app graphite-app Bot deleted the 06-10-feat_formatter_json_implement_json-stringify_variant branch June 10, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur