fix(linter): allow options for eslint/capitalized-comments#23139
Merged
graphite-app[bot] merged 1 commit intoJun 9, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
camc314
approved these changes
Jun 9, 2026
Contributor
Merge activity
|
e6c5b80 to
8f3db61
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 9, 2026
follow up from #23139 Added tests when a test-case has an option but the `rule.has_config()`, making sure this code path will never hit for rules which should have a config: https://github.com/oxc-project/oxc/blob/01b74c4e84696950add4b813b0dfa2600c459f09/crates/oxc_linter/src/config/rules.rs#L158-L165 On the way I found some rules where the test-cases shown us options for rules, which we do not support atm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23122
was introduced in #22984, where we removed the
config =line.