refactor(linter/config): do not import from globals.ts manually#22927
Merged
graphite-app[bot] merged 1 commit intoJun 3, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns apps/oxlint/src-js with the existing TSDown replace_globals transform by removing the manual import of global wrappers from utils/globals.ts and using the corresponding native global property accesses (JSON.stringify, Date.now) directly.
Changes:
- Removed manual imports of
DateNowandJSONStringifyfrom./utils/globals.ts. - Replaced
DateNow()withDate.now(). - Replaced
JSONStringify(...)withJSON.stringify(...)in config loader return paths.
Contributor
Merge activity
|
…2927) There's no need to import globals from `globals.ts` manually. TSDown plugin does this transform automatically. (I sense the hand of an LLM here)
5235247 to
1f96534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to import globals from
globals.tsmanually. TSDown plugin does this transform automatically. (I sense the hand of an LLM here)