docs(tasks): correct commands for running tests#22891
Merged
graphite-app[bot] merged 1 commit intoJun 1, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
180f54f to
5b0081f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor/docs guidance for running Node.js (NAPI) test suites by switching from pnpm build-dev to the correct pnpm run build-test workflow, aligning e2e and agent instructions with how NAPI test builds are intended to be produced.
Changes:
- Updated
tasks/e2einstructions to build the required NAPI packages usingbuild-testbefore running e2e tests. - Updated
AGENTS.mdNAPI testing commands to usepnpm run build-test(and adjusted package-specific instructions accordingly).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tasks/e2e/README.md | Documents the correct sequence to build NAPI minify/transform for tests, then run the e2e suite. |
| AGENTS.md | Updates the NAPI testing section to reference build-test (including package-specific examples). |
5b0081f to
ad63e24
Compare
Member
Author
Merge activity
|
`pnpm run build-test` is the correct command for building NAPI packages for running tests, not `pnpm build-dev`. Correct the docs accordingly. Also clarify the commands for running e2e tests.
ad63e24 to
494c043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm run build-testis the correct command for building NAPI packages for running tests, notpnpm build-dev. Correct the docs accordingly. Also clarify the commands for running e2e tests.