fix(parser): reject TypeScript declarations in single-statement context by Boshen · Pull Request #22827 · oxc-project/oxc

Boshen · 2026-05-29T09:57:40Z

No description provided.

Boshen · 2026-05-29T09:58:55Z

Merge activity

May 29, 9:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 29, 10:14 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 29, 10:14 AM UTC: Boshen added this pull request to the Graphite merge queue.
May 29, 10:20 AM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (All comments in this PR must be resolved before merging. Once you've resolved all open comment threads, you can retry your merge.).
May 29, 4:47 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
May 29, 4:47 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
May 29, 4:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 31, 8:44 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
May 31, 8:44 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 31, 9:07 AM UTC: Boshen added this pull request to the Graphite merge queue.
May 31, 9:07 AM UTC: Merged by the Graphite merge queue.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96b28513a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codspeed-hq · 2026-05-29T10:05:45Z

Merging this PR will not alter performance

✅ 57 untouched benchmarks

_{Comparing fix/ts-decl-single-statement (96b2851) with main (9d3d4f7)¹}

No successful run was found on main (a769b33) during the generation of this report, so 9d3d4f7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Boshen · 2026-05-29T10:15:38Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

…xt (#22827)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76c50ce231

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60f0b51d3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…xt (#22827)

### 🚀 Features - 9c71f2e ast, codegen, formatter: Add `WithClauseKeyword::as_str` helper and use it (#22791) (camc314) ### 🐛 Bug Fixes - cf5769c parser: Reject TypeScript declarations in single-statement context (#22827) (Boshen) - c360fb6 parser: Reject generators in ambient contexts and overload signatures (TS1221/TS1222) (#22848) (Boshen) - cc60d8d parser: Reject invalid index signature parameter types (TS1268/TS1337) (#22852) (Boshen) - 3d13e29 parser: Reject `declare` in an already-ambient context (TS1038) (#22850) (Boshen) - 5152854 parser: Reject statements in ambient contexts (TS1036) (#22849) (Boshen) - 4f9afc5 parser: Reject `export as namespace` inside a namespace body (TS1316) (#22846) (Boshen) - 2eafea6 parser: Reject function implementations in ambient contexts (TS1183) (#22845) (Boshen) - c645615 parser: Reject incompatible class member modifiers (#22843) (Boshen) - 276b78b parser: Reject module-referencing imports/exports in a namespace body (#22836) (Boshen) - 842ed1c parser: Parse `class implements` with `implements` as the class name (#22801) (Boshen) ### ⚡ Performance - 7e3a567 parser: Reuse cached token kind in delimited-list loops (#22841) (Boshen) - 9e741c2 parser: Use peek_token instead of lookahead on the modifier path (#22842) (Boshen) - 9e496a7 semantic: Defer declare lookup for empty accessors (#22810) (camc314)

github-actions Bot added the A-parser Area - Parser label May 29, 2026

Boshen added the 0-merge Merge with Graphite Merge Queue label May 29, 2026

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread crates/oxc_parser/src/ts/statement.rs

Boshen mentioned this pull request May 29, 2026

fix(parser): reject 'const' modifier on type alias type parameter #22828

Closed

Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels May 29, 2026

Boshen force-pushed the fix/ts-decl-single-statement branch from 96b2851 to efa7b94 Compare May 29, 2026 10:15

graphite-app Bot pushed a commit that referenced this pull request May 29, 2026

fix(parser): reject TypeScript declarations in single-statement conte…

76c50ce

…xt (#22827)

graphite-app Bot force-pushed the fix/ts-decl-single-statement branch from efa7b94 to 76c50ce Compare May 29, 2026 10:15

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread crates/oxc_parser/src/ts/statement.rs

graphite-app Bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels May 29, 2026

Boshen force-pushed the fix/ts-decl-single-statement branch from 76c50ce to 60f0b51 Compare May 29, 2026 10:56

Boshen mentioned this pull request May 29, 2026

fix(parser): reject module-referencing imports/exports in a namespace body #22829

Merged

chatgpt-codex-connector Bot reviewed May 29, 2026

View reviewed changes

Comment thread crates/oxc_parser/src/ts/statement.rs

fix(parser): reject TypeScript declarations in single-statement conte…

cf5769c

…xt (#22827)

Boshen force-pushed the fix/ts-decl-single-statement branch from 60f0b51 to cf5769c Compare May 31, 2026 08:25

Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels May 31, 2026

graphite-app Bot merged commit cf5769c into main May 31, 2026
31 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 31, 2026

graphite-app Bot deleted the fix/ts-decl-single-statement branch May 31, 2026 09:07

oxc-guard Bot mentioned this pull request Jun 1, 2026

release(crates): oxc v0.134.0 #22882

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(parser): reject TypeScript declarations in single-statement context#22827

fix(parser): reject TypeScript declarations in single-statement context#22827
graphite-app[bot] merged 1 commit into
mainfrom
fix/ts-decl-single-statement

Boshen commented May 29, 2026 •

edited

Loading

Uh oh!

Boshen commented May 29, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented May 29, 2026

Uh oh!

Boshen commented May 29, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Boshen commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Boshen commented May 29, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codspeed-hq Bot commented May 29, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Boshen commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Boshen commented May 29, 2026 •

edited

Loading

Boshen commented May 29, 2026 •

edited by graphite-app Bot

Loading

Boshen commented May 29, 2026 •

edited

Loading