Skip to content

refactor(semantic): clarify comments of handling parameter decorator resolving#22702

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-25-refactor_semantic_clarify_comments_of_handling_parameter_decorator_resolving
May 25, 2026
Merged

refactor(semantic): clarify comments of handling parameter decorator resolving#22702
graphite-app[bot] merged 1 commit into
mainfrom
05-25-refactor_semantic_clarify_comments_of_handling_parameter_decorator_resolving

Conversation

@Dunqing

@Dunqing Dunqing commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is a follow-up to #22623. I forgot to commit the working changes and push to that PR.

@github-actions github-actions Bot added the A-semantic Area - Semantic label May 25, 2026
@Dunqing Graphite App

Dunqing commented May 25, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review May 25, 2026 01:16
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label May 25, 2026
@Dunqing Dunqing requested a review from camc314 May 25, 2026 01:17
@Dunqing Graphite App

Dunqing commented May 25, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

graphite-app Bot pushed a commit that referenced this pull request May 25, 2026
@Dunqing
refactor(semantic): clarify comments of handling parameter decorator …
a5622fb 
…resolving (#22702)

This is a follow-up to #22623. I forgot to commit the working changes and push to that PR.
@graphite-app graphite-app Bot force-pushed the 05-25-refactor_semantic_clarify_comments_of_handling_parameter_decorator_resolving branch from fd9c567 to a5622fb Compare May 25, 2026 01:19
@codspeed-hq

codspeed-hq Bot commented May 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 8 skipped benchmarks1

Comparing 05-25-refactor_semantic_clarify_comments_of_handling_parameter_decorator_resolving (fd9c567) with main (fa7c463)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing
refactor(semantic): clarify comments of handling parameter decorator …
057bb1f 
…resolving (#22702)

This is a follow-up to #22623. I forgot to commit the working changes and push to that PR.
@graphite-app graphite-app Bot force-pushed the 05-25-refactor_semantic_clarify_comments_of_handling_parameter_decorator_resolving branch from a5622fb to 057bb1f Compare May 25, 2026 01:22
@graphite-app graphite-app Bot merged commit 057bb1f into main May 25, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 25, 2026
@graphite-app graphite-app Bot deleted the 05-25-refactor_semantic_clarify_comments_of_handling_parameter_decorator_resolving branch May 25, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314

Assignees

No one assigned

Labels

A-semantic Area - Semantic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing