Skip to content

perf(semantic): avoid duplicate ident clone for bindings#22663

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/05-21-perf_semantic_avoid_duplicate_ident_clone_for_bindings
May 22, 2026
Merged

perf(semantic): avoid duplicate ident clone for bindings#22663
graphite-app[bot] merged 1 commit into
mainfrom
c/05-21-perf_semantic_avoid_duplicate_ident_clone_for_bindings

Conversation

@camc314

@camc314 camc314 commented May 21, 2026

Copy link
Copy Markdown
Contributor

Avoid cloning identifier names twice when creating a semantic symbol and adding its scope binding.

Ident is Copy, so create_symbol_with_binding now clones the name into the semantic arena once, then stores that same arena-backed ident in both the symbol name table and the bindings map. This also lets the catch-parameter shadow binding path use the same helper.

Fixture Before (num allocs) After (num allocs) num alloc Delta Before (num reallocs) After (num reallocs) num realloc Delta
TypeScript checker.ts 53020 37851 -15169 (-28.61%) 22022 22022 0 (0.00%)
Excalidraw App.tsx 6824 4936 -1888 (-27.67%) 2229 2229 0 (0.00%)
RadixUIAdoptionSection.jsx 36 25 -11 (-30.56%) 14 14 0 (0.00%)
pdf.mjs 16507 11977 -4530 (-27.44%) 5101 5101 0 (0.00%)
Ant Design antd.js 143881 100200 -43681 (-30.36%) 30529 30529 0 (0.00%)
TypeScript binder.ts 3642 2557 -1085 (-29.79%) 1447 1447 0 (0.00%)
kitchen-sink.tsx 25635 18651 -6984 (-27.24%) 6363 6363 0 (0.00%)

@github-actions github-actions Bot added the A-semantic Area - Semantic label May 21, 2026

camc314 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented May 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/05-21-perf_semantic_avoid_duplicate_ident_clone_for_bindings (3c7365f) with main (868e2e8)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 marked this pull request as ready for review May 21, 2026 21:56
@camc314 camc314 requested a review from Dunqing as a code owner May 21, 2026 21:56
Copilot AI review requested due to automatic review settings May 21, 2026 21:56
@camc314

camc314 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Hmm slightly dissapointed, was hoping for a bigger improvement given how many few arena allocations are made: it seems to get ~1%.

Semantic Benches:

Screenshot 2026-05-21 at 22 57 13

Pipeline Benches
Screenshot 2026-05-21 at 22 58 18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves oxc_semantic binding creation performance by avoiding cloning identifier names twice when declaring a symbol and inserting its scope binding. It centralizes “create symbol + bind” into a single helper that clones the Ident into the arena once and reuses that arena-backed Ident for both the symbol name table and the bindings map.

Changes:

  • Added Scoping::create_symbol_with_binding to create a symbol and insert its binding while cloning the identifier name only once into the arena.
  • Updated SemanticBuilder symbol declaration paths to use the new helper (including the shadow-binding path).
  • Removed the now-redundant insert_binding helper.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_semantic/src/scoping.rs Adds create_symbol_with_binding and removes insert_binding to eliminate duplicate arena clones during symbol+binding creation.
crates/oxc_semantic/src/builder.rs Switches symbol declaration and shadow declaration paths to the new single-clone helper.

@Dunqing Dunqing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Claude code found the same optimization in #22666 🤣

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label May 22, 2026

Dunqing commented May 22, 2026

Copy link
Copy Markdown
Member

Merge activity

Avoid cloning identifier names twice when creating a semantic symbol and adding its scope binding.

`Ident` is `Copy`, so `create_symbol_with_binding` now clones the name into the semantic arena once, then stores that same arena-backed ident in both the symbol name table and the bindings map. This also lets the catch-parameter shadow binding path use the same helper.

| Fixture                    | Before (num allocs) | After (num allocs) | num alloc Delta | Before (num reallocs) | After (num reallocs) | num realloc Delta |
| -------------------------- | -------------------:| ------------------:| ---------------:| ----------------------:| ---------------------:| -----------------:|
| TypeScript `checker.ts` | 53020 | 37851 | -15169 (-28.61%) | 22022 | 22022 | 0 (0.00%) |
| Excalidraw `App.tsx` | 6824 | 4936 | -1888 (-27.67%) | 2229 | 2229 | 0 (0.00%) |
| `RadixUIAdoptionSection.jsx` | 36 | 25 | -11 (-30.56%) | 14 | 14 | 0 (0.00%) |
| `pdf.mjs` | 16507 | 11977 | -4530 (-27.44%) | 5101 | 5101 | 0 (0.00%) |
| Ant Design `antd.js` | 143881 | 100200 | -43681 (-30.36%) | 30529 | 30529 | 0 (0.00%) |
| TypeScript `binder.ts` | 3642 | 2557 | -1085 (-29.79%) | 1447 | 1447 | 0 (0.00%) |
| `kitchen-sink.tsx` | 25635 | 18651 | -6984 (-27.24%) | 6363 | 6363 | 0 (0.00%) |
@graphite-app graphite-app Bot force-pushed the c/05-21-perf_semantic_avoid_duplicate_ident_clone_for_bindings branch from 3c7365f to 4b6add2 Compare May 22, 2026 00:47
@graphite-app graphite-app Bot merged commit 4b6add2 into main May 22, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 22, 2026
@graphite-app graphite-app Bot deleted the c/05-21-perf_semantic_avoid_duplicate_ident_clone_for_bindings branch May 22, 2026 00:51
Dunqing added a commit that referenced this pull request May 22, 2026
…ctions

`check_identifier`, `check_identifier_reference`, and
`check_binding_identifier` run on every identifier-class AST node when
`with_check_syntax_error(true)` is set (the configuration used by
`oxc_linter`, `oxc::compiler`, and most embedders). Each one only does
real work for a small fixed set of reserved-word names:

- `check_identifier`: `await` plus 9 strict-mode contextual keywords.
- `check_identifier_reference`: `arguments` and `eval`.
- `check_binding_identifier`: `eval`, `arguments`, and `let`.

The vast majority of identifiers — every `foo`, `useState`, `render`,
`props`, etc. — would fall through to no error. They were nonetheless
paying the cost of an `is_typescript_definition` check plus, depending
on the function, an `is_current_node_ambient_binding` call (loads scope
flags + symbol flags), a `strict_mode()` scope-flags load, or both.

Add a leading `matches!` against the relevant name set in each function.
If the name is not in the set, return immediately. The match dispatches
by length first, so non-matching names of unrelated lengths cost a
single length check; same-length-as-a-keyword names cost one extra
memcmp.

Also add a `< 2 properties` early-exit to `check_object_expression` —
a `__proto__` duplicate requires at least two property definitions, and
JSX/TSX call sites emit huge numbers of single-property object literals
(`<Foo prop={x}>` → `{prop: x}`).

Benchmark (`cargo bench --bench semantic --no-default-features --features compiler`,
criterion vs `oxc-project/main` after #22663):

- RadixUIAdoptionSection.jsx: -1.43%
- react.development.js:       -1.93%
- cal.com.tsx:                -0.20% (within noise)
- binder.ts:                  -2.05%
- kitchen-sink.tsx:           -1.00%

Four of five are statistically significant (p < 0.05).

Verified by `cargo test -p oxc_semantic --features cfg` (72 tests),
`cargo clippy -p oxc_semantic --all-features`, and
`cargo coverage -- semantic` (snapshot counts unchanged: 45575/47095
test262, 2035/2236 babel, 2671/4773 typescript, 52/66 misc).
Dunqing added a commit that referenced this pull request May 26, 2026
### 🚀 Features

- e857b0c napi/minify: Expose legalComments option and result (#20370)
(Boshen)
- 661132d parser: More friendly error messages for rest assignment
target and rest binding element (#22719) (sapphi-red)
- ee659b6 transformer/legacy-decorator: Add `strictNullChecks` option
for nullable-union design:type (#22266) (Kyle Cannon)

### 🐛 Bug Fixes

- e1d064e transformer/class-properties: Reparent lifted private method
helpers (#22716) (Cameron)
- 4ac0fca minifier: Preserve `0 && (module.exports = { ... })`
cjs-module-lexer hint (#22729) (Dunqing)
- 40ff611 minifier: Mark peephole loop changed when dropping
dead-after-throw statement (#22722) (Dunqing)
- 2f7b210 codegen: Emit pife-arrow/function leading comments inside the
wrap (#22720) (Dunqing)
- e184f74 parser: Improve invalid `import` property access diagnostic
(#22693) (camc314)
- 7baed9c transformer/private-method: Clear inherited strict flags
(#22508) (camc314)
- a9ad27e parser: Keep annotation comments leading without preceding
newline (#22711) (Dunqing)
- 9ea4d64 minifier: Re-evaluate pure/no-side-effects flags after
peephole inlining (#22595) (Dunqing)
- 07afbb6 minifier: Drop empty-body IIFE wrapper when called with
arguments (#22589) (Dunqing)
- fa7c463 semantic: Correct TS enum member symbol spans (#22689)
(camc314)
- 26b9396 semantic: Resolve parameter decorators outside parameter scope
(#22623) (camc314)
- b284045 parser: Switch to module goal eagerly on `export` (#22684)
(Boshen)
- dfa931d semantic: Propagate unresolved auto-increment enum value
instead of defaulting to 0 (#22646) (Dunqing)
- 69a6ba6 transformer/legacy-decorator: Emit Array for ReadonlyArray<T>
in decorator metadata (#22265) (Kyle Cannon)
- e421ef0 transformer/legacy-decorator: Return runtime binding for
design:type (#22640) (Dunqing)
- d61e1d7 codegen: Preserve verbatim text of pure/no-side-effects
comments (#22525) (Dunqing)
- 702b14e minifier: Preserve IIFE structure in DCE-only mode (#22547)
(Dunqing)
- 917da24 parser: Apply PURE comment through member-access chains
(#22566) (Dunqing)
- a069b1c codegen: Preserve quotes for cjs-module-lexer equality strings
(#22551) (Dunqing)

### ⚡ Performance

- 2f623b0 semantic: Skip unresolved checks for re-exports (#22660)
(camc314)
- 0d9553d semantic: Early-exit `check_object_expression` for objects
with <2 properties (#22668) (Dunqing)
- d721ad9 semantic: Use direct grandparent lookup for TS type parameters
(#22658) (camc314)
- 0aff288 semantic: Reorder numeric literal strict mode checks (#22657)
(camc314)
- 4d5ddb1 semantic: Reorder binding identifier checks (#22656) (camc314)
- e32acd8 semantic: Reorder identifier ambient binding check (#22653)
(camc314)
- 09fe178 semantic: Reorder ident reference strict mode check (#22652)
(camc314)
- 4b6add2 semantic: Avoid duplicate ident clone for bindings (#22663)
(camc314)
- 82f9662 parser: Check identifier kind before context flag (#22662)
(camc314)
- d7cd951 parser: Fast path identifier parsing and inline operator
helpers (#22650) (Boshen)
- 7b84314 semantic: Use direct byte access for numeric leading-zero
check (#22642) (camc314)
- 0345a31 semantic: Pre-size class elements hash map (#22618) (camc314)
- 04d3065 minifier: Drop per-call buffers in try_fold_concat (#22596)
(Dunqing)
- 4f289f1 semantic: Resolve_references_for_current_scope without a temp
Vec (#22599) (Dunqing)
- e862c15 semantic: Avoid heap alloc for var hoist scope ids (#22603)
(Dunqing)
- 8ff8674 semantic: Early return if `excess` is `0` in
`Stats::increase_by` (#22616) (camc314)
- 7a4120e semantic: Pre-reserve unresolved_references using
Stats::references (#22580) (Dunqing)

Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants