Skip to content

ci(track-memory-allocations): Run ci on task change#22614

Merged
camc314 merged 2 commits into
mainfrom
05-20-ci_track-memory-allocations_run_ci_on_task_change
May 21, 2026
Merged

ci(track-memory-allocations): Run ci on task change#22614
camc314 merged 2 commits into
mainfrom
05-20-ci_track-memory-allocations_run_ci_on_task_change

Conversation

@leaysgur

@leaysgur leaysgur commented May 20, 2026

Copy link
Copy Markdown
Member

Investigating the issue where unrelated changes causing the transformer.snap diffs and CI fails.

Fixed the comments to get the CI actually run.


Ah, I've reproduced it... 🫠
On my end, no changes are generated in the snapshot.

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing

Dunqing commented May 20, 2026

Copy link
Copy Markdown
Member

Solved in #22621, do we still need this?

Comment thread .github/workflows/ci.yml
@leaysgur leaysgur force-pushed the 05-20-ci_track-memory-allocations_run_ci_on_task_change branch from 36b0bea to bc2eabd Compare May 21, 2026 01:03
@leaysgur

Copy link
Copy Markdown
Member Author

do we still need this?

I do think so.

Because this wasn't in place, CI wasn't triggered for your PRs.

It looks like this is why we're seeing snapshot diffs even in the current main branch. 👉🏻 I updated snapshot in this PR.

@leaysgur leaysgur requested a review from Dunqing May 21, 2026 01:15
Comment thread tasks/track_memory_allocations/src/lib.rs Outdated
Signed-off-by: Cameron <cameron.clark@hey.com>

@camc314 camc314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@camc314 camc314 merged commit 42e448f into main May 21, 2026
26 checks passed
@camc314 camc314 deleted the 05-20-ci_track-memory-allocations_run_ci_on_task_change branch May 21, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants