refactor(formatter/sort_imports): Wrap every Comment with label#22514
Merged
graphite-app[bot] merged 1 commit intoMay 18, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Comment with label
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
Member
Author
|
/oxfmt-ecosys |
…2514) Standardize how the `sort_imports` IR transform identifies comments. Previously it mixed two strategies: - a label (`JsLabels::AlignableBlockComment`) for multi-line block comments only - and a textual prefix check (`text.starts_with("//") || "/*")`) for everything else The textual path was fragile against IR shapes that don't fit the assumption, formatted JSDoc emitting a `Token`/`Text` mix is the most visible case (see #22486). This PR unifies both paths under a single label: every emitted comment is wrapped in `JsLabels::Comment`, and classification becomes a pure structural check.
Contributor
Oxfmt Ecosystem CI
|
1e587b0 to
8ee946f
Compare
eb06c47 to
c9f506e
Compare
Base automatically changed from
05-18-fix_formatter_sort_imports_use_label_to_classify_lines
to
main
May 18, 2026 01:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize how the
sort_importsIR transform identifies comments.Previously it mixed two strategies:
JsLabels::AlignableBlockComment) for multi-line block comments onlytext.starts_with("//") || "/*")) for everything elseThe textual path was fragile against IR shapes that don't fit the assumption, formatted JSDoc emitting a
Token/Textmix is the most visible case (see #22486).This PR unifies both paths under a single label: every emitted comment is wrapped in
JsLabels::Comment, and classification becomes a pure structural check.