refactor(oxlint,oxfmt): Share src-js code via apps/shared#22452
Merged
graphite-app[bot] merged 1 commit intoMay 18, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 15, 2026
src-js code via apps/shared
camc314
reviewed
May 15, 2026
2e98c6d to
a39e030
Compare
camc314
approved these changes
May 18, 2026
camc314
left a comment
Contributor
There was a problem hiding this comment.
not sure if "shared" is the right name, but the rest LGTM
Contributor
Merge activity
|
New place to share code for use in `src-js`, similar to how `crates/oxc_config` works. Initially, I considered creating an `apps/oxc_cli` and moving `crates/oxc_config` there. However, it felt unnatural deps for `crates/oxc_linter` -> `apps/oxc_cli`, so I decided to keep the Rust code as is for now and share only the JS code. Since `apps/shared` exports `.ts` files directly, each app is responsible for bundling them via `@oxapps/shared`. Tests still live in `apps/shared`, so separate CI is also added and hooked by each app. To start, I've only shared the function that reports TS incompatibility errors. This is just for verification purposes and will be fixed in a later PR.
a39e030 to
37d49fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New place to share code for use in
src-js, similar to howcrates/oxc_configworks.Initially, I considered creating an
apps/oxc_cliand movingcrates/oxc_configthere. However, it felt unnatural deps forcrates/oxc_linter->apps/oxc_cli, so I decided to keep the Rust code as is for now and share only the JS code.Since
apps/sharedexports.tsfiles directly, each app is responsible for bundling them via@oxapps/shared. Tests still live inapps/shared, so separate CI is also added and hooked by each app.To start, I've only shared the function that reports TS incompatibility errors. This is just for verification purposes and will be fixed in a later PR.