fix(formatter/sort_imports): treat submodule imports as internal patterns#22371
Closed
Jungzl wants to merge 1 commit into
Closed
fix(formatter/sort_imports): treat submodule imports as internal patterns#22371Jungzl wants to merge 1 commit into
Jungzl wants to merge 1 commit into
Conversation
Member
|
Thank you! |
graphite-app Bot
pushed a commit
that referenced
this pull request
May 15, 2026
Closes #22371, follows azat-io/eslint-plugin-perfectionist#732 --- As a baseline, while the result effectively follows the behavior of a perfectionist, there is no fundamental reason why it must be done that way. Node.js subpaths are more flexible and aren't necessarily "internal", you can also alias external modules. However, I do think it's consistent in the sense that it treats them the same way as other conventions like `@`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see azat-io/eslint-plugin-perfectionist#732