fix(ci): pin mimalloc-safe to 0.1.58#22329
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
Pins mimalloc-safe to an exact version in the workspace to avoid a known upstream regression that breaks the aarch64-pc-windows-msvc release build, and updates the lockfile accordingly.
Changes:
- Pin workspace dependency
mimalloc-safeto=0.1.58to prevent Cargo from selecting newer patch versions. - Update
Cargo.lockto resolvemimalloc-safeto0.1.58, which downgradeslibmimalloc-sys2to0.1.54.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Pins mimalloc-safe to =0.1.58 at the workspace dependency level. |
| Cargo.lock | Updates the resolved versions/checksums to match the pinned allocator dependency set. |
## Summary Pins the workspace `mimalloc-safe` dependency to `=0.1.58` and updates `Cargo.lock` so `libmimalloc-sys2` is downgraded from `0.1.55` to `0.1.54`. ## Why The `Build Oxfmt aarch64-pc-windows-msvc` release job started failing after the dependency set moved to `mimalloc-safe 0.1.59` / `libmimalloc-sys2 0.1.55`. The failing log shows clang compiling mimalloc for `aarch64-pc-windows-msvc` and hitting undeclared MSVC ARM64 atomics (`__ldar64` / `__stlr64`). The same workflow target passed on May 5 with `mimalloc-safe 0.1.58` / `libmimalloc-sys2 0.1.54`. This is intended as a narrow release unblock while the upstream mimalloc-safe regression is handled separately.
7092da4 to
fb2a970
Compare
shulaoda
added a commit
to rolldown/rolldown
that referenced
this pull request
May 12, 2026
## Summary Pins the workspace `mimalloc-safe` dependency to `=0.1.58` so `libmimalloc-sys2` stays on `0.1.54` instead of being resolved to `0.1.55`. ## Why The `Build aarch64-pc-windows-msvc` job in `reusable-release-build.yml` started failing after the dependency set moved to `mimalloc-safe 0.1.59` / `libmimalloc-sys2 0.1.55`. clang fails to compile mimalloc for `aarch64-pc-windows-msvc` with undeclared MSVC ARM64 atomics: ``` ./c_src/mimalloc/include/mimalloc/atomic.h:230:14: error: call to undeclared function '__ldar64' ./c_src/mimalloc/include/mimalloc/atomic.h:252:7: error: call to undeclared function '__stlr64' ... error: failed to run custom build command for `libmimalloc-sys2 v0.1.55` ``` Failing run: https://github.com/rolldown/rolldown/actions/runs/25691372335/job/75431916428 Same regression and same fix as oxc-project/oxc#22329. Intended as a narrow unblock while the upstream `mimalloc-safe` / `libmimalloc-sys2` regression is handled separately.
IWANABETHATGUY
pushed a commit
to rolldown/rolldown
that referenced
this pull request
May 18, 2026
## Summary Pins the workspace `mimalloc-safe` dependency to `=0.1.58` so `libmimalloc-sys2` stays on `0.1.54` instead of being resolved to `0.1.55`. ## Why The `Build aarch64-pc-windows-msvc` job in `reusable-release-build.yml` started failing after the dependency set moved to `mimalloc-safe 0.1.59` / `libmimalloc-sys2 0.1.55`. clang fails to compile mimalloc for `aarch64-pc-windows-msvc` with undeclared MSVC ARM64 atomics: ``` ./c_src/mimalloc/include/mimalloc/atomic.h:230:14: error: call to undeclared function '__ldar64' ./c_src/mimalloc/include/mimalloc/atomic.h:252:7: error: call to undeclared function '__stlr64' ... error: failed to run custom build command for `libmimalloc-sys2 v0.1.55` ``` Failing run: https://github.com/rolldown/rolldown/actions/runs/25691372335/job/75431916428 Same regression and same fix as oxc-project/oxc#22329. Intended as a narrow unblock while the upstream `mimalloc-safe` / `libmimalloc-sys2` regression is handled separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the workspace
mimalloc-safedependency to=0.1.58and updatesCargo.locksolibmimalloc-sys2is downgraded from0.1.55to0.1.54.Why
The
Build Oxfmt aarch64-pc-windows-msvcrelease job started failing after the dependency set moved tomimalloc-safe 0.1.59/libmimalloc-sys2 0.1.55. The failing log shows clang compiling mimalloc foraarch64-pc-windows-msvcand hitting undeclared MSVC ARM64 atomics (__ldar64/__stlr64). The same workflow target passed on May 5 withmimalloc-safe 0.1.58/libmimalloc-sys2 0.1.54.This is intended as a narrow release unblock while the upstream mimalloc-safe regression is handled separately.