refactor(linter/no-map-spread): use is_scope_descendant_of api#22314
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the no-map-spread linter rule’s callback-scope check to use the new semantic scoping helper is_scope_descendant_of, aligning linter logic with the centralized scoping API introduced in #22313.
Changes:
- Replace manual
scope_ancestors(...).any(...)traversal withis_scope_descendant_of(...). - Preserve the prior behavior by explicitly allowing the “same scope” case (
declaration_scope == cb_scope_id) since the helper defines “descendant” as excluding self.
712bae8 to
14d2c00
Compare
88f9f35 to
70ff54a
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
14d2c00 to
3ccf46c
Compare
3ccf46c to
44313da
Compare
Member
Merge activity
|
70ff54a to
6e355b4
Compare
camc314
added a commit
that referenced
this pull request
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on #22313