Skip to content

test(linter/no-param-reassign): cover this computed key assignment#22303

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/test-linter-no-param-reassign-this-key
May 11, 2026
Merged

test(linter/no-param-reassign): cover this computed key assignment#22303
graphite-app[bot] merged 1 commit into
mainfrom
codex/test-linter-no-param-reassign-this-key

Conversation

@camc314

@camc314 camc314 commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • add no-param-reassign regression cases for assignments through this[key]

Stacked on #22302.

Related to #22300

Copilot AI review requested due to automatic review settings May 11, 2026 08:04
@camc314 camc314 self-assigned this May 11, 2026
@github-actions github-actions Bot added the A-linter Area - Linter label May 11, 2026
Copilot AI reviewed May 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds regression coverage for no-param-reassign to ensure assignments performed via computed member expressions like this[key] don’t incorrectly trigger parameter reassignment/property-modification diagnostics (especially when props: true), including a TypeScript this-parameter signature variant.

Changes:

  • Add passing test cases for this[key] simple assignment, compound assignment (+=), and delete.
  • Add a TypeScript-annotated function signature case (generic + explicit this parameter) to ensure the computed-key path remains clean under TS syntax.

@codspeed-hq

codspeed-hq Bot commented May 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1

Comparing codex/test-linter-no-param-reassign-this-key (187d80f) with codex/fix-semantic-computed-member-key (ec0c6f2)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label May 11, 2026
@graphite-app graphite-app Bot force-pushed the codex/fix-semantic-computed-member-key branch from f5f7a33 to a7c3e22 Compare May 11, 2026 08:49
Base automatically changed from codex/fix-semantic-computed-member-key to main May 11, 2026 08:53
@Dunqing Graphite App

Dunqing commented May 11, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member

Merge activity

  • May 11, 8:53 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 11, 8:53 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • May 11, 8:53 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • May 11, 8:53 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 11, 9:04 AM UTC: Dunqing added this pull request to the Graphite merge queue.
  • May 11, 9:09 AM UTC: Merged by the Graphite merge queue.

@camc314 camc314 force-pushed the codex/test-linter-no-param-reassign-this-key branch from 187d80f to a74a9b0 Compare May 11, 2026 09:01
@camc314
test(linter/no-param-reassign): cover this computed key assignment (#…
f3ed565 
…22303)

- add `no-param-reassign` regression cases for assignments through `this[key]`

Stacked on #22302.

Related to #22300
@graphite-app graphite-app Bot force-pushed the codex/test-linter-no-param-reassign-this-key branch from a74a9b0 to f3ed565 Compare May 11, 2026 09:05
@graphite-app graphite-app Bot merged commit f3ed565 into main May 11, 2026
28 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 11, 2026
@graphite-app graphite-app Bot deleted the codex/test-linter-no-param-reassign-this-key branch May 11, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Dunqing Dunqing Dunqing approved these changes

Assignees

@camc314 camc314

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @Dunqing