Skip to content

test(linter/sort-keys): add multiline value autofix regression#22070

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/sort-keys-multiline-value-fix
May 2, 2026
Merged

test(linter/sort-keys): add multiline value autofix regression#22070
graphite-app[bot] merged 1 commit into
mainfrom
codex/sort-keys-multiline-value-fix

Conversation

@camc314

@camc314 camc314 commented May 2, 2026

Copy link
Copy Markdown
Contributor

Adds a regression test for eslint/sort-keys autofixing nested objects with multiline values, fixes #20830.

Copilot AI review requested due to automatic review settings May 2, 2026 09:42
@camc314 camc314 added the A-linter Area - Linter label May 2, 2026
@camc314 camc314 self-assigned this May 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression test to ensure eslint/sort-keys autofix can reorder nested object keys correctly when some property values are formatted across multiple lines (e.g., outline: followed by an indented value on the next line), addressing the broken-output scenario from #20830.

Changes:

  • Add a new expect_fix test case covering nested objects with a multiline-formatted value.
  • Assert correct key reordering at multiple nesting levels (defaultVariants, variants, and nested size keys).

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 2, 2026

camc314 commented May 2, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

Adds a regression test for eslint/sort-keys autofixing nested objects with multiline values, fixes #20830.
@graphite-app graphite-app Bot force-pushed the codex/sort-keys-multiline-value-fix branch from 0082c3d to 8b40f7b Compare May 2, 2026 09:46
@graphite-app graphite-app Bot merged commit 8b40f7b into main May 2, 2026
27 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 2, 2026
@graphite-app graphite-app Bot deleted the codex/sort-keys-multiline-value-fix branch May 2, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: eslint/sort-keys autofix results in broken output syntax

2 participants