feat(linter): Split `jest/require-to-throw-message` into Jest and Vitest rules. by connorshea · Pull Request #21879 · oxc-project/oxc

connorshea · 2026-04-28T03:48:23Z

Generated with Claude Code, reviewed by me.

Part of #21664.

codspeed-hq · 2026-04-28T03:54:54Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks¹

_{Comparing require-throw-rule (f56712c) with main (2d102fd)}

47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314

Thanks!

camc314 · 2026-04-28T07:35:44Z

Merge activity

Apr 28, 7:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 28, 7:35 AM UTC: camc314 added this pull request to the Graphite merge queue.
Apr 28, 7:38 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
Apr 28, 7:39 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 28, 7:43 AM UTC: camc314 added this pull request to the Graphite merge queue.
Apr 28, 7:48 AM UTC: Merged by the Graphite merge queue.

…est rules. (#21879) Generated with Claude Code, reviewed by me. Part of #21664.

Copilot

Pull request overview

Splits the previously “Vitest-compatible” jest/require-to-throw-message rule into a dedicated vitest/require-to-throw-message rule while sharing the core implementation between Jest and Vitest.

Changes:

Removed require-to-throw-message from the VITEST_COMPATIBLE_JEST_RULES list and the corresponding JSON sync file.
Added a new vitest/require-to-throw-message rule and registered it in the rule registry / generated enums / runner impls.
Refactored the rule logic + documentation into a shared rules/shared/jest_vitest/require_to_throw_message module, used by both Jest and Vitest rules.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_linter/src/utils/mod.rs	Removes the rule from the “Vitest-compatible Jest rules” list (now that a real Vitest rule exists).
crates/oxc_linter/src/snapshots/vitest_require_to_throw_message.snap	Adds snapshot output coverage for the new Vitest rule.
crates/oxc_linter/src/rules/vitest/require_to_throw_message.rs	Introduces the dedicated Vitest rule wrapper + Vitest-specific test/snapshot.
crates/oxc_linter/src/rules/shared/jest_vitest/require_to_throw_message.rs	Adds shared implementation and shared documentation for Jest/Vitest.
crates/oxc_linter/src/rules/shared/jest_vitest/mod.rs	Exposes the new shared module.
crates/oxc_linter/src/rules/jest/require_to_throw_message.rs	Switches Jest rule to use the shared implementation and keeps Jest-only tests/snapshot.
crates/oxc_linter/src/rules.rs	Registers the new Vitest rule module.
crates/oxc_linter/src/generated/rules_enum.rs	Registers the new Vitest rule in the generated enum/metadata/config plumbing.
crates/oxc_linter/src/generated/rule_runner_impls.rs	Adds the generated `RuleRunner` impl for the new Vitest rule.
crates/oxc_linter/data/vitest_compatible_jest_rules.json	Removes the rule from the synced “Vitest-compatible Jest rules” JSON list.

…est rules. (#21879) Generated with Claude Code, reviewed by me. Part of #21664.

camc314 · 2026-04-28T07:47:02Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

# Oxlint ### 🚀 Features - 1d40d60 linter: Implement SARIF formatter (#22067) (camchenry) - c0982fe linter/eslint: Implement no-restricted-properties rule (#22080) (AJ Bienz) - 5699d53 linter: Add help text to `agent` formatter (#22064) (camchenry) - fe7194d oxlint: Add agent output mode (#21955) (Jovi De Croock) - fb2f052 linter: Suggest moving shared branch code (#22022) (camc314) - 5868335 linter/no-else-return: Improve nested if diagnostic spans (#22009) (camc314) - 8b4829b linter: Split `no-negated-condition` rule to unicorn & eslint (#21998) (Sysix) - fea301a linter: Split jest/prefer-to-be into separate vitest rule (#21977) (camchenry) - 44aa0d6 linter: Split jest/prefer-strict-equal into separate vitest rule (#21976) (camchenry) - 2262b27 linter: Split jest/prefer-spy-on into separate vitest rule (#21975) (camchenry) - fef9143 linter: Split jest/prefer-mock-return-shorthand into separate vitest rule (#21974) (camchenry) - 2bda504 linter: Split jest/prefer-mock-promise-shorthand into separate vitest rule (#21973) (camchenry) - 6ef6c7d linter: Split jest/prefer-lowercase into separate vitest rule (#21972) (camchenry) - f4d2498 linter: Split jest/prefer-hooks-on-top into separate vitest rule (#21971) (camchenry) - fb8e366 linter: Split jest/prefer-hooks-in-order into separate vitest rule (#21970) (camchenry) - adcd85c linter: Split jest/prefer-expect-resolves into separate vitest rule (#21969) (camchenry) - 8ddc7ec linter: Split jest/prefer-equality-matcher into separate vitest rule (#21968) (camchenry) - 46bb1f3 linter: Split jest/prefer-each into separate vitest rule (#21967) (camchenry) - bdbff66 linter: Implement interactive-supports-focus (#21767) (mehm8128) - 733b094 linter: Split `prefer-to-have-been-called-times` rule (#21898) (Said Atrahouch) - 8804425 linter/eslint: Implement `logical-assignment-operators` rule (#21900) (Mikhail Baev) - 296d147 linter: Split jest/prefer-comparison-matcher into separate vitest rule (#21929) (camchenry) - 38146b6 linter: Split jest/prefer-called-with into separate vitest rule (#21927) (camchenry) - 6f86175 linter/vue: Implement return-in-computed-property rule (#21909) (bab) - dc2d0e4 linter: Split jest/no-unneeded-async-expect-function into separate vitest rule (#21878) (camchenry) - a03fc37 linter: Split jest/no-test-return-statement into separate vitest rule (#21877) (camchenry) - f11313e linter: Split jest/no-test-prefixes into separate vitest rule (#21876) (camchenry) - 4380812 linter: Split `prefer-to-have-length` rule (#21893) (Said Atrahouch) - 511bcc1 linter: Split jest `require-hook` rule (#21889) (Said Atrahouch) - 64a8180 linter: Split `jest/prefer-snapshot-hint` into a Jest rule and a Vitest rule. (#21881) (connorshea) - ae7924a linter/vue: Implement no-deprecated-model-definition rule (#21886) (bab) - 0dfe8b3 linter: Split `jest/require-to-throw-message` into Jest and Vitest rules. (#21879) (connorshea) - 51229ff linter: Split jest `valid-describe-callback` rule (#21882) (Said Atrahouch) - 2d102fd linter: Split `no-standalone-expect` rule into jest and vitest (#21862) (Sysix) - ee46a29 linter: Split `no-restricted-matchers` rule into jest and vitest (#21860) (Sysix) - 1f29459 linter: Split `no-restricted-jest-methods` rule into jest and vitest (#21859) (Sysix) - e7f8d55 linter: Remove eslint prefixes from plugin names in diagnostics (#21806) (Connor Shea) - 89fff8b linter: Split valid-expect-in-promise/jest rule into jest and vitest rules (#21854) (Said Atrahouch) ### 🐛 Bug Fixes - 0b48848 linter/prefer-array-some: Make find rewrite a suggestion (#22103) (camc314) - d24027e linter/prefer-array-some: Preserve find comparison fixes (#22094) (camc314) - af2d26c linter/astro: Handle js `---` after frontmatter in .astro files (#22091) (Andrew Powell) - 78d4ff0 linter/jsdoc/require-returns: Only look at the nearest jsdoc block (#22077) (camc314) - fa88857 linter/no-map-spread: Use default codegen options for fix (#22074) (camc314) - 2047a35 linter: Treat adjacent fixes as overlapping (#22071) (camc314) - 75fc551 linter: Handle no-extra-boolean-cast edge cases (#22031) (camc314) - e9d5284 linter/sort-keys: Don't autofix if comment could be misplaced (#22052) (Amund Eggen Svandal) - d7230b0 linter/no-constant-condition: Handle generator yields (#22046) (camc314) - e8dbc56 linter/array-type: Enable edge case tests (#22047) (camc314) - d57b51f linter/no-constant-condition: Propagate config errors (#22045) (camc314) - bdb6d95 linter/typescript: Remove duplicate rule tests (#22044) (camc314) - 0beaffc linter: Print resolved extended config (#22040) (camc314) - 192ad0e linter/react/only-export-components: Align rule with upstream cases (#22039) (camc314) - cdf4c53 linter/only-export-components: Support tanstack router (#21937) (camc314) - 893e18f linter: Stop gitignore lookup at repo boundary (#22033) (camc314) - 7100712 linter/constructor-super: Clarify duplicate super diagnostics (#22035) (camc314) - fce5b7c linter/constructor-super: Improve invalid `super` calls diagnostic (#22032) (camc314) - b3de93c linter/rules-of-hooks: Clarify conditional diagnostics (#22030) (camc314) - 4f9f629 linter/rules-of-hooks: Clarify loop diagnostics (#22029) (camc314) - e6f0978 linter/rules-of-hooks: Clarify async component diagnostics (#22024) (camc314) - e262f51 linter/rules-of-hooks: Improve diagnostic for hook inside class component (#22023) (camc314) - 7b71b0d linter/no-restricted-imports: Report once per import declaration (#22021) (camc314) - 3d5ae3d linter/vitest/require-mock-type-parameters: Handle chained typed mocks (#22019) (camc314) - 959a2db linter/reporter/github: Omit empty `file` annotations (#22017) (camc314) - 16003a1 linter/unicorn: Remove duplicate rule tests (#22018) (camc314) - 86b7547 linter/no-unreachable: Suppress nested unreachable diagnostics (#22011) (camc314) - 1d92ae8 linter/oxc: Remove duplicate rule tests (#22013) (camc314) - f270246 linter/branches-sharing-code: Ignore empty statements (#22012) (camc314) - f1c25dd linter: Stabilize debug diagnostic comparison (#22010) (camc314) - b6bc421 linter: Skip linting astro scripts with non JS script types (#21954) (camc314) - a77547d linter: Support plugin-qualified disable directives (#21999) (camc314) - 079cfdd linter: Match disable directive rule names exactly, not by substring (#21906) (Christian Vuerings) - 11a4e67 linter: Comptibles rules need to be disabled in jest and vitest at same time (#21982) (Said Atrahouch) - ce62f16 linter: `jsx-a11y/prefer-tag-over-role` detect more roles (#21933) (bab) - 024c390 linter/jest/vitest: Padding around after all blocks not working as expected (#21952) (kapobajza) - 05a8f75 linter/jest/no-standalone-expect: False positive with expect in an `ObjectProperty` (#21948) (Said Atrahouch) - 6a37c98 linter/no-unused-vars: Report unused re-exported imports (#21938) (camc314) - 2d5fc16 linter: `jsx-a11y/media-has-caption` report only once for self-closing tags (#21934) (bab) - 5adca29 linter: `jsx-a11y/no-autofocus` ignore `false` attribute values (#21918) (Sysix) - 2e5c18e linter/max-nested-describe: Reset nested describe depth (#21891) (camc314) ### ⚡ Performance - a77f0f7 linter/require-returns: Avoid jsdoc tag vec allocation (#22081) (camc314) - d9a1b32 linter/plugins: Avoid array lookups where possible in CFG visitor (#21940) (overlookmotel) - fefefd8 linter/plugins: Replace addition with bitwise OR in CFG visitor (#21939) (overlookmotel) ### 📚 Documentation - d58f594 oxlint/lsp: Auto generate docs for LSP options (#22082) (Sysix) - 9adc3b3 linter/no-misused-new: Clarify construct signatures behaviour (#22016) (camc314) - 1caf5ad linter/plugins: Reformat comments (#21873) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - ef0db6b formatter: Sequence expression in arrow function body collapses onto one line (#21183) (Justin Mecham) - 5d5d808 formatter: Preserve blank line after directive with trailing comment (#21153) (Justin Mecham) ### ⚡ Performance - 2fd907d formatter: Sort imports during IR construction (#22065) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron Clark <cameron.clark@hey.com>

connorshea marked this pull request as ready for review April 28, 2026 03:51

connorshea requested a review from camc314 as a code owner April 28, 2026 03:51

Copilot AI review requested due to automatic review settings April 28, 2026 03:51

camc314 requested review from Copilot and removed request for Copilot April 28, 2026 07:34

camc314 approved these changes Apr 28, 2026

View reviewed changes

Copilot started reviewing on behalf of camc314 April 28, 2026 07:34 View session

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2026

camc314 self-assigned this Apr 28, 2026

graphite-app Bot pushed a commit that referenced this pull request Apr 28, 2026

feat(linter): Split jest/require-to-throw-message into Jest and Vit…

83f782d

…est rules. (#21879) Generated with Claude Code, reviewed by me. Part of #21664.

graphite-app Bot force-pushed the require-throw-rule branch from f56712c to 83f782d Compare April 28, 2026 07:36

Copilot AI reviewed Apr 28, 2026

View reviewed changes

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2026

camc314 pushed a commit that referenced this pull request Apr 28, 2026

feat(linter): Split jest/require-to-throw-message into Jest and Vit…

ce272c0

…est rules. (#21879) Generated with Claude Code, reviewed by me. Part of #21664.

camc314 force-pushed the require-throw-rule branch from 83f782d to ce272c0 Compare April 28, 2026 07:39

camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2026

feat(linter): Split jest/require-to-throw-message into Jest and Vit…

0dfe8b3

…est rules. (#21879) Generated with Claude Code, reviewed by me. Part of #21664.

graphite-app Bot force-pushed the require-throw-rule branch from 99d1332 to 0dfe8b3 Compare April 28, 2026 07:44

camc314 mentioned this pull request Apr 28, 2026

feat(linter): Split jest/prefer-snapshot-hint into a Jest rule and a Vitest rule. #21881

Merged

graphite-app Bot merged commit 0dfe8b3 into main Apr 28, 2026
27 checks passed

graphite-app Bot deleted the require-throw-rule branch April 28, 2026 07:48

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2026

oxc-guard Bot mentioned this pull request May 4, 2026

release(apps): oxlint v1.63.0 && oxfmt v0.48.0 #22109

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): Split `jest/require-to-throw-message` into Jest and Vitest rules.#21879

feat(linter): Split `jest/require-to-throw-message` into Jest and Vitest rules.#21879
graphite-app[bot] merged 1 commit intomainfrom
require-throw-rule

connorshea commented Apr 28, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 28, 2026

Uh oh!

camc314 left a comment

Uh oh!

camc314 commented Apr 28, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

connorshea commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Apr 28, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

camc314 commented Apr 28, 2026

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

connorshea commented Apr 28, 2026 •

edited

Loading

camc314 commented Apr 28, 2026 •

edited by graphite-app Bot

Loading