fix(formatter): handle same-line comment after pipe in single-member union types#21824
Closed
babu-ch wants to merge 2 commits into
Closed
fix(formatter): handle same-line comment after pipe in single-member union types#21824babu-ch wants to merge 2 commits into
babu-ch wants to merge 2 commits into
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
e795087 to
89f750e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
That is a suspicious issue that may be a bug in Prettier rather than in us, even though the output matched Prettier. Need to double-check in #18717 |
Contributor
Author
|
@Dunqing |
Member
Can you try to double-check first? I forgot half the issues I listed in that and just remembered that the union with comments case in Prettier is very buggy. 😅 |
Contributor
Author
|
Double-checked the union-related issues in #18717. This case doesn't appear to match any of them. |
…ment-after-pipe-same-line
leaysgur
added a commit
that referenced
this pull request
Jun 22, 2026
…rmatting (#21915) Fixes #21914, Fixes #21792, Supersedes #21824. Tests for union type are taken from #21824. ### Comment printing Changes to comment printing for single member union/intersection types try to mimic: https://github.com/prettier/prettier/blob/f5e3980c3085f6fb2b166c8e3f91e8db317d6eb2/src/main/comments/attach.js#L183-L190 Where own-line comments are leading, and: https://github.com/prettier/prettier/blob/f5e3980c3085f6fb2b166c8e3f91e8db317d6eb2/src/main/comments/attach.js#L200-L206 Where end-of-line comments are trailing (note that this doesn't apply to block comments, see https://github.com/prettier/prettier/blob/870b6df76058cc6c1c23418524d0272141c50677/src/language-js/comments/handle-comments.js#L764), and: https://github.com/prettier/prettier/blob/f5e3980c3085f6fb2b166c8e3f91e8db317d6eb2/src/main/comments/attach.js#L324-L328 Where inline comments are leading if they're separated only by whitespace, open parentheses or other comments from the node after them. Because of that, current behavior is to consider inline comments trailing if they're before the `&` or `|` symbol (as they can't be leading, because `&` and `|` aren't whitespace). --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Yuji Sugiura <6259812+leaysgur@users.noreply.github.com>
Member
|
Fixed by #21915 (Anyway, thank you for your assistance~!) |
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
…rmatting (#21915) Fixes #21914, Fixes #21792, Supersedes #21824. Tests for union type are taken from #21824. ### Comment printing Changes to comment printing for single member union/intersection types try to mimic: https://github.com/prettier/prettier/blob/f5e3980c3085f6fb2b166c8e3f91e8db317d6eb2/src/main/comments/attach.js#L183-L190 Where own-line comments are leading, and: https://github.com/prettier/prettier/blob/f5e3980c3085f6fb2b166c8e3f91e8db317d6eb2/src/main/comments/attach.js#L200-L206 Where end-of-line comments are trailing (note that this doesn't apply to block comments, see https://github.com/prettier/prettier/blob/870b6df76058cc6c1c23418524d0272141c50677/src/language-js/comments/handle-comments.js#L764), and: https://github.com/prettier/prettier/blob/f5e3980c3085f6fb2b166c8e3f91e8db317d6eb2/src/main/comments/attach.js#L324-L328 Where inline comments are leading if they're separated only by whitespace, open parentheses or other comments from the node after them. Because of that, current behavior is to consider inline comments trailing if they're before the `&` or `|` symbol (as they can't be leading, because `&` and `|` aren't whitespace). --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Yuji Sugiura <6259812+leaysgur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21792