perf(ast_tools): combine 2 loops over enum variants#21705
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes ast_tools code generation for enum node_id() accessors by merging two separate variant-validation passes into a single loop, reducing repeated iteration work during generation.
Changes:
- Combine “all variants have node_id-capable inner structs” and “all variants boxed” checks into one pass in
generate_for_enum. - Remove the now-unneeded
type_has_node_idhelper and related import. - Keep generated output behavior the same (including conditional
#[inline(always)]when all variants are boxed).
This was referenced Apr 24, 2026
Contributor
Merge activity
|
Follow-on after #21653. Combine 2 loops over enums' variants into a single loop. Should be a little faster.
69a8b6c to
fa66a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #21653. Combine 2 loops over enums' variants into a single loop. Should be a little faster.