Skip to content

ci(tools): replace action-semantic-pull-request with inline regex#21631

Merged
Boshen merged 1 commit into
mainfrom
ci/inline-pr-title-check
Apr 22, 2026
Merged

ci(tools): replace action-semantic-pull-request with inline regex#21631
Boshen merged 1 commit into
mainfrom
ci/inline-pr-title-check

Conversation

@Boshen

@Boshen Boshen commented Apr 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace amannn/action-semantic-pull-request with a ~10-line inline bash check (grep -E against the title).
  • No external action to pin or upgrade; no pull-requests: read token permission needed (title comes from the event payload).
  • Same trigger, same 12-type allowlist, same required-scope enforcement — behavior is equivalent.
  • Adds reopened to the trigger types so the check re-runs when a PR is reopened.
  • Drops the if: github.repository == 'oxc-project/oxc' guard so forks can still run the check locally if they want.

The regex is tuned to the scopes oxc actually uses ([a-z0-9/_-]+, matches e.g. linter/sort-keys, transformer/typescript, oxfmt/lsp). Failure output uses ::error:: so the reason shows directly on the PR checks UI.

Drops the third-party GitHub Action in favor of a ~10-line bash check.
No external action to pin or upgrade, no token permissions needed,
and behavior is equivalent: same trigger, same 12-type allowlist,
same required-scope enforcement. Also adds `reopened` to trigger
types so the check re-runs on reopened PRs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Boshen Boshen merged commit 861036f into main Apr 22, 2026
24 checks passed
@Boshen Boshen deleted the ci/inline-pr-title-check branch April 22, 2026 04:22
graphite-app Bot pushed a commit to rolldown/rolldown that referenced this pull request May 12, 2026
Since #9188 replaced `pull_request_target` with `pull_request` trigger, `amannn/action-semantic-pull-request` no longer works. To fix that, this PR replaces that with a bash script using grep.

refs oxc-project/oxc#21631
IWANABETHATGUY pushed a commit to rolldown/rolldown that referenced this pull request May 18, 2026
Since #9188 replaced `pull_request_target` with `pull_request` trigger, `amannn/action-semantic-pull-request` no longer works. To fix that, this PR replaces that with a bash script using grep.

refs oxc-project/oxc#21631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant