Skip to content

refactor(formatter): Simplify comment detection conditions in union type formatting#21513

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-17-refactor_formatter_simplify_comment_detection_conditions_in_union_type_formatting
Apr 17, 2026
Merged

refactor(formatter): Simplify comment detection conditions in union type formatting#21513
graphite-app[bot] merged 1 commit intomainfrom
04-17-refactor_formatter_simplify_comment_detection_conditions_in_union_type_formatting

Conversation

@leaysgur
Copy link
Copy Markdown
Member

@leaysgur leaysgur commented Apr 17, 2026

Follow up on #21487

@leaysgur leaysgur requested a review from Dunqing as a code owner April 17, 2026 00:12
@leaysgur Graphite App
Copy link
Copy Markdown
Member Author

leaysgur commented Apr 17, 2026

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 17, 2026
@leaysgur leaysgur force-pushed the 04-17-refactor_formatter_simplify_comment_detection_conditions_in_union_type_formatting branch from 81c02e5 to fdefb12 Compare April 17, 2026 00:16
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Apr 17, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 17, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 7 skipped benchmarks1

Comparing 04-17-refactor_formatter_simplify_comment_detection_conditions_in_union_type_formatting (fdefb12) with main (a501a53)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur Graphite App
Copy link
Copy Markdown
Member Author

leaysgur commented Apr 17, 2026 •
edited by graphite-app Bot
Loading

Merge activity

@graphite-app graphite-app Bot force-pushed the 04-17-refactor_formatter_simplify_comment_detection_conditions_in_union_type_formatting branch from fdefb12 to 4a16b32 Compare April 17, 2026 00:20
@graphite-app graphite-app Bot merged commit 4a16b32 into main Apr 17, 2026
26 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 17, 2026
@graphite-app graphite-app Bot deleted the 04-17-refactor_formatter_simplify_comment_detection_conditions_in_union_type_formatting branch April 17, 2026 00:24
This was referenced Apr 17, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur