Skip to content

chore(deps): update dependency rust to v1.95.0#21509

Merged
graphite-app[bot] merged 1 commit intomainfrom
renovate/rust-toolchain
Apr 17, 2026
Merged

chore(deps): update dependency rust to v1.95.0#21509
graphite-app[bot] merged 1 commit intomainfrom
renovate/rust-toolchain

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate Bot commented Apr 16, 2026

This PR contains the following updates:

Package Update Change
rust minor 1.94.1 → 1.95.0

Release Notes

rust-lang/rust (rust)

v1.95.0

Compare Source

Configuration

📅 Schedule: (in timezone Asia/Shanghai)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions github-actions Bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 16, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 16, 2026 •
edited
Loading

Merging this PR will degrade performance by 8.36%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 43 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation minifier[react.development.js] 2.8 ms 2.7 ms +3.83%
❌ Simulation lexer[cal.com.tsx] 5.5 ms 6 ms -8.36%
❌ Simulation lexer[RadixUIAdoptionSection.jsx] 21.4 µs 22.5 µs -5.11%
❌ Simulation lexer[react.development.js] 362 µs 391.4 µs -7.5%
❌ Simulation lexer[binder.ts] 894.6 µs 964 µs -7.2%

Comparing renovate/rust-toolchain (90fed76) with main (ddb1bf8)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (df27b48) during the generation of this report, so ddb1bf8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@renovate renovate Bot force-pushed the renovate/rust-toolchain branch 5 times, most recently from d1d38d5 to 93c0145 Compare April 17, 2026 04:47
@github-actions github-actions Bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-editor Area - Editor and Language Server A-formatter Area - Formatter A-allocator Area - Allocator labels Apr 17, 2026
@renovate
Copy link
Copy Markdown
Contributor Author

renovate Bot commented Apr 17, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@camc314 camc314 mentioned this pull request Apr 17, 2026
Open
camc314
camc314 approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I investigate the perf regression, and have made an issue in rust repo, although it appears to be an llvm regression rust-lang/rust#155422.

There is a workaround we can change our code to emit the same assembly - #21523

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 17, 2026
@Boshen Graphite App
Copy link
Copy Markdown
Member

Boshen commented Apr 17, 2026 •
edited by graphite-app Bot
Loading

Merge activity

@renovate
chore(deps): update dependency rust to v1.95.0 (#21509)
611b3b6 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rust](https://redirect.github.com/rust-lang/rust) | minor | `1.94.1` → `1.95.0` |

---

### Release Notes

<details>
<summary>rust-lang/rust (rust)</summary>

### [`v1.95.0`](https://redirect.github.com/rust-lang/rust/compare/1.94.1...1.95.0)

[Compare Source](https://redirect.github.com/rust-lang/rust/compare/1.94.1...1.95.0)

</details>

---

### Configuration

📅 **Schedule**: (in timezone Asia/Shanghai)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/oxc-project/oxc).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMjMuOCIsInVwZGF0ZWRJblZlciI6IjQzLjEyMy44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
@graphite-app graphite-app Bot force-pushed the renovate/rust-toolchain branch from 90fed76 to 611b3b6 Compare April 17, 2026 14:43
@graphite-app graphite-app Bot merged commit 611b3b6 into main Apr 17, 2026
27 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 17, 2026
@graphite-app graphite-app Bot deleted the renovate/rust-toolchain branch April 17, 2026 15:00
@overlookmotel overlookmotel mentioned this pull request Apr 22, 2026
Merged
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
@overlookmotel
perf(lexer): fix perf of Token::set_* methods on Rust 1.95.0 (#21659)
2290f31 
`Token`'s `set_*` methods used safe bitwise ops to write "fields" of `Token`.

Unfortunately this regressed heavily in Rust 1.95.0, due to a bug in LLVM. Methods which were a single scalar op turned into a string of heavy SIMD ops, impacting performance.

* #21509
* rust-lang/rust#155422

Re-implement these methods using unsafe pointer manipulation, which recovers the original assembly, and reverses the perf regression - gains 3% on parser benchmarks.

The original implementations are left in the code as comments, in case we want to revert to them once the LLVM bug is fixed.
@camc314 camc314 mentioned this pull request Apr 23, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner

Assignees

No one assigned

Labels

A-allocator Area - Allocator A-ast-tools Area - AST tools A-cli Area - CLI A-codegen Area - Code Generation A-editor Area - Editor and Language Server A-formatter Area - Formatter A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen @camc314