Skip to content

refactor(allocator): simplify code in Vec#21393

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/04-13-refactor_allocator_simplify_code_in_vec_
Apr 13, 2026
Merged

refactor(allocator): simplify code in Vec#21393
graphite-app[bot] merged 1 commit into
mainfrom
om/04-13-refactor_allocator_simplify_code_in_vec_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This code was introduced in #11092 to work around an oddity with Miri. It should be safe to remove now.

@overlookmotel Graphite App

overlookmotel commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 13, 2026
@codspeed-hq

codspeed-hq Bot commented Apr 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-13-refactor_allocator_simplify_code_in_vec_ (89a9f3d) with main (44b5b35)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel self-assigned this Apr 13, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 13, 2026 18:13
Copilot AI review requested due to automatic review settings April 13, 2026 18:13
Copilot AI reviewed Apr 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a previously-added Miri/Clippy workaround in oxc_allocator’s bump-allocated Vec, simplifying Vec::append_elements now that the workaround is no longer needed under the current MSRV.

Changes:

  • Removed the #[allow(...)] workaround and its explanatory comments in Vec::append_elements.
  • Simplified slice length retrieval from (&*other).len() to other.len() for *const [T].

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026
@overlookmotel Graphite App

overlookmotel commented Apr 13, 2026 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member Author

Merge activity

@overlookmotel
refactor(allocator): simplify code in Vec (#21393)
2e144c2 
This code was introduced in #11092 to work around an oddity with Miri. It should be safe to remove now.
@graphite-app graphite-app Bot force-pushed the om/04-13-refactor_allocator_simplify_code_in_vec_ branch from 89a9f3d to 2e144c2 Compare April 13, 2026 18:21
@graphite-app graphite-app Bot merged commit 2e144c2 into main Apr 13, 2026
27 checks passed
@graphite-app graphite-app Bot deleted the om/04-13-refactor_allocator_simplify_code_in_vec_ branch April 13, 2026 18:26
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel