Skip to content

feat(tasks/linter): set rulegen version to next in template#21370

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/rulegen-version-next
Apr 13, 2026
Merged

feat(tasks/linter): set rulegen version to next in template#21370
graphite-app[bot] merged 1 commit intomainfrom
c/rulegen-version-next

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Apr 13, 2026

Copilot AI review requested due to automatic review settings April 13, 2026 08:17
Copy link
Copy Markdown
Contributor Author

camc314 commented Apr 13, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 changed the title feat(linter): set rulegen version to next feat(tasks/linter): set rulegen version to next Apr 13, 2026
@github-actions github-actions Bot added the C-enhancement Category - New feature or request label Apr 13, 2026
@camc314 camc314 changed the title feat(tasks/linter): set rulegen version to next feat(linter): set rulegen version to next Apr 13, 2026
@camc314 camc314 self-assigned this Apr 13, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026
Copy link
Copy Markdown
Contributor Author

camc314 commented Apr 13, 2026

Merge activity

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the rule generator template so newly generated linter rules include a version field in their declare_oxc_lint! metadata, aligning generated output with the template snapshot tests.

Changes:

  • Add version = "next" to the declare_oxc_lint! block in the rulegen template.
  • Update the rulegen render snapshot to include the new version line.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tasks/rulegen/template.txt Adds a default version metadata entry to generated rule declarations.
tasks/rulegen/src/snapshots/rulegen__template__tests__rulegen_template_render.snap Updates snapshot output to match the new template rendering.

Comment thread tasks/rulegen/template.txt
@camc314 camc314 changed the title feat(linter): set rulegen version to next feat(tasks/linter): set rulegen version to next in tempalte Apr 13, 2026
@camc314 camc314 changed the title feat(tasks/linter): set rulegen version to next in tempalte feat(tasks/linter): set rulegen version to next in template Apr 13, 2026
graphite-app Bot pushed a commit that referenced this pull request Apr 13, 2026
- follow up to #21363 by setting `version = "next"` in the rulegen template for newly scaffolded lint rules
- update the rulegen template snapshot to match
@graphite-app graphite-app Bot force-pushed the c/rulegen-version-next branch from 4423855 to 82e3fac Compare April 13, 2026 08:24
- follow up to #21363 by setting `version = "next"` in the rulegen template for newly scaffolded lint rules
- update the rulegen template snapshot to match
@graphite-app graphite-app Bot force-pushed the c/rulegen-version-next branch from 82e3fac to 00089f2 Compare April 13, 2026 08:28
@graphite-app graphite-app Bot merged commit 00089f2 into main Apr 13, 2026
24 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 13, 2026
@graphite-app graphite-app Bot deleted the c/rulegen-version-next branch April 13, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants