Skip to content

test(allocator): fix Bump test on 32-bit platforms#21309

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms
Apr 24, 2026
Merged

test(allocator): fix Bump test on 32-bit platforms#21309
graphite-app[bot] merged 1 commit intomainfrom
om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 10, 2026 •
edited
Loading

Fix a test for Bump which was failing on 32-bit in CI.

#21291 temporarily disabled the test. Turn out, there's no easy way to make this test work on 32-bit platforms, and #21510 added ample unit tests which effectively test the same thing.

So keep it disabled on 32-bit, but fix the test to make it work properly on 64-bit.

Rationale for the fix is explained in fitzgen/bumpalo#320.

@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 10, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-allocator Area - Allocator C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Apr 10, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 10, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms (7462c4a) with main (adbc7dc)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (7462c4a) during the generation of this report, so adbc7dc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel self-assigned this Apr 10, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 10, 2026 10:52
Copilot AI review requested due to automatic review settings April 10, 2026 10:52
Copilot AI reviewed Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Bump allocator OOM regression test so it no longer gets skipped on 32-bit targets, aiming to make CI consistently green across architectures.

Changes:

  • Re-enables oom_instead_of_bump_pointer_overflow on non-miri 32-bit by removing the target_pointer_width = "64" gate.
  • Adjusts the test setup to prevent allocating a new chunk via set_allocation_limit.
  • Changes the “overflowing” allocation size computation to use a value derived from the allocated pointer address.

Comment thread crates/oxc_allocator/tests/bump/tests.rs Outdated
@overlookmotel overlookmotel force-pushed the om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms branch 2 times, most recently from 7ff745a to ed6f0ab Compare April 24, 2026 10:46
@overlookmotel overlookmotel mentioned this pull request Apr 24, 2026
Merged
@overlookmotel overlookmotel force-pushed the om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms branch from ed6f0ab to 8ab35c8 Compare April 24, 2026 12:03
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 24, 2026 •
edited
Loading

Merge activity

@overlookmotel
test(allocator): fix Bump test on 32-bit platforms (#21309)
7462c4a 
Fix a test for `Bump` which was failing on 32-bit in CI.

#21291 temporarily disabled the test. Turn out, there's no easy way to make this test work on 32-bit platforms, and #21510 added ample unit tests which effectively test the same thing.

So keep it disabled on 32-bit, but fix the test to make it work properly on 64-bit.

Rationale for the fix is explained in fitzgen/bumpalo#320.
@graphite-app graphite-app Bot force-pushed the om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms branch from 8ab35c8 to 7462c4a Compare April 24, 2026 12:23
@graphite-app graphite-app Bot merged commit 7462c4a into main Apr 24, 2026
36 checks passed
@graphite-app graphite-app Bot deleted the om/04-10-test_allocator_fix_bump_test_on_32-bit_platforms branch April 24, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel