Skip to content

refactor(allocator): rename var#21282

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_allocator_rename_var
Apr 10, 2026
Merged

refactor(allocator): rename var#21282
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_allocator_rename_var

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026 •
edited
Loading

Pure refactor. Just rename a var to be more descriptive.

@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@overlookmotel overlookmotel self-assigned this Apr 9, 2026
@github-actions github-actions Bot added A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 9, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 9, 2026 23:41
Copilot AI review requested due to automatic review settings April 9, 2026 23:41
Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the bump allocator implementation by renaming the footer-size constant to a more descriptive name, improving readability without changing behavior.

Changes:

  • Renamed FOOTER_SIZE to CHUNK_FOOTER_SIZE.
  • Updated all internal uses (allocation sizing, reset logic, growth calculations, and tests) to the new name.

Comment thread crates/oxc_allocator/src/bump.rs
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-09-refactor_allocator_rename_var (562c8d0) with main (17aee9e)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel force-pushed the om/04-09-refactor_allocator_rename_var branch from 6b49410 to 562c8d0 Compare April 9, 2026 23:48
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 10, 2026
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 10, 2026 •
edited by graphite-app Bot
Loading

Merge activity

@overlookmotel
refactor(allocator): rename var (#21282)
c400e99 
Pure refactor. Just rename a var to be more descriptive.
@graphite-app graphite-app Bot force-pushed the om/04-09-refactor_allocator_rename_var branch from 562c8d0 to c400e99 Compare April 10, 2026 00:29
@graphite-app graphite-app Bot merged commit c400e99 into main Apr 10, 2026
27 checks passed
@graphite-app graphite-app Bot deleted the om/04-09-refactor_allocator_rename_var branch April 10, 2026 00:33
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel