Skip to content

refactor(allocator): switch to non-deprecated stdlib error types#21260

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_allocator_switch_to_non-deprecated_stdlib_error_types
Apr 9, 2026
Merged

refactor(allocator): switch to non-deprecated stdlib error types#21260
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_allocator_switch_to_non-deprecated_stdlib_error_types

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026 •
edited
Loading

Use LayoutError instead of the deprecated alias LayoutErr.

This was referenced Apr 9, 2026
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@github-actions github-actions Bot added A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 9, 2026
@overlookmotel overlookmotel self-assigned this Apr 9, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 9, 2026 13:51
Copilot AI review requested due to automatic review settings April 9, 2026 13:51
Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the allocator shim to use std::alloc::LayoutError instead of the deprecated alias LayoutErr, and removes the file-level allowance for deprecated items.

Changes:

  • Replace LayoutErr with LayoutError in imports and public method signatures.
  • Update new_layout_err() to return LayoutError.
  • Remove #![allow(deprecated)] now that the deprecated alias is no longer used.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-09-refactor_allocator_switch_to_non-deprecated_stdlib_error_types (dc157cb) with om/04-09-refactor_allocator_remove_deny_attributes (8d27f40)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 9, 2026
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026 •
edited by graphite-app Bot
Loading

Merge activity

@overlookmotel
refactor(allocator): switch to non-deprecated stdlib error types (#21260
64cb025 
)

Use `LayoutError` instead of the deprecated alias `LayoutErr`.
@graphite-app graphite-app Bot force-pushed the om/04-09-refactor_allocator_remove_deny_attributes branch from 8d27f40 to 9f0b9fe Compare April 9, 2026 14:44
@graphite-app graphite-app Bot force-pushed the om/04-09-refactor_allocator_switch_to_non-deprecated_stdlib_error_types branch from dc157cb to 64cb025 Compare April 9, 2026 14:45
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 9, 2026
Base automatically changed from om/04-09-refactor_allocator_remove_deny_attributes to main April 9, 2026 14:57
@graphite-app graphite-app Bot merged commit 64cb025 into main Apr 9, 2026
28 checks passed
@graphite-app graphite-app Bot deleted the om/04-09-refactor_allocator_switch_to_non-deprecated_stdlib_error_types branch April 9, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel