Skip to content

refactor(str): re-order Ident trait impls#21250

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_str_re-order_ident_trait_impls
Apr 9, 2026
Merged

refactor(str): re-order Ident trait impls#21250
graphite-app[bot] merged 1 commit intomainfrom
om/04-09-refactor_str_re-order_ident_trait_impls

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026 •
edited
Loading

Pure refactor. Re-order trait impls for Ident to stardard order - stdlib traits first in order of importance, then Oxc traits (e.g. CloneIn, FromIn).

The PR does not alter any code at all, just moves it.

@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@github-actions github-actions Bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 9, 2026
@overlookmotel overlookmotel self-assigned this Apr 9, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 9, 2026 12:53
Copilot AI review requested due to automatic review settings April 9, 2026 12:54
Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Reorders Ident trait implementations in oxc_str to match the project’s standard ordering (stdlib traits first, then Oxc-specific traits), without changing behavior.

Changes:

  • Moved Send/Sync, Deref, AsRef, Clone/Copy, and Eq impl blocks to align with a consistent trait-impl ordering.
  • Relocated Oxc trait impls (CloneIn, Dummy, FromIn, Equivalent) into the designated section.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-09-refactor_str_re-order_ident_trait_impls (4a4850e) with main (7213d61)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (4a4850e) during the generation of this report, so 7213d61 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 9, 2026 •
edited
Loading

Merge activity

@overlookmotel
refactor(str): re-order Ident trait impls (#21250)
4a4850e 
Pure refactor. Re-order trait impls for `Ident` to stardard order - stdlib traits first in order of importance, then Oxc traits (e.g. `CloneIn`, `FromIn`).

The PR does not alter any code at all, just moves it.
@graphite-app graphite-app Bot force-pushed the om/04-09-refactor_str_re-order_ident_trait_impls branch from f831d1c to 4a4850e Compare April 9, 2026 13:01
@graphite-app graphite-app Bot merged commit 4a4850e into main Apr 9, 2026
34 checks passed
@graphite-app graphite-app Bot deleted the om/04-09-refactor_str_re-order_ident_trait_impls branch April 9, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel