feat(linter): remove the --timings feature#2049
Merged
Merged
Conversation
For a various reasons: This features bloats the code size. We have many tools for profiling in Rust (as compared to ESLint where the feature came from), so a built-in feature is not really needed anymore. ESLint needed `--timings` because it needs to monitor plugins. We control all our code so we don't need this.
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Member
Author
CodSpeed Performance ReportMerging #2049 will improve performances by 40.53%Comparing Summary
Benchmarks breakdown
|
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
For a various reasons: This features bloats the code size. We have many tools for profiling in Rust (as compared to ESLint where the feature came from), so a built-in feature is not really needed anymore. ESLint needed `--timings` because it needs to monitor plugins. We control all our code so we don't need this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a various reasons:
This features bloats the code size.
We have many tools for profiling in Rust (as compared to ESLint where the feature came from),
so a built-in feature is not really needed anymore.
ESLint needed
--timingsbecause it needs to monitor plugins.We control all our code so we don't need this.