Skip to content

test(linter/plugins): fix stack traces in conformance snapshots#20473

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-15-test_linter_plugins_fix_stack_traces_in_conformance_snapshots
Mar 21, 2026
Merged

test(linter/plugins): fix stack traces in conformance snapshots#20473
graphite-app[bot] merged 1 commit intomainfrom
om/03-15-test_linter_plugins_fix_stack_traces_in_conformance_snapshots

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 17, 2026 •
edited
Loading

Fix bug in conformance test runner. It was removing some lines from stack traces where errors occur.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Mar 17, 2026
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 17, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 17, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review March 17, 2026 23:46
@overlookmotel overlookmotel requested a review from camc314 as a code owner March 17, 2026 23:46
Copilot AI review requested due to automatic review settings March 17, 2026 23:46
Copilot AI reviewed Mar 17, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes stack-trace formatting in the oxlint conformance test report so that frames without :line:col are no longer dropped from the generated markdown snapshots.

Changes:

  • Relax stack trace line parsing to allow frames that don’t include :line:col.
  • Ensure missing line:col groups don’t propagate as undefined during formatting.
  • Update the stylistic conformance snapshot to reflect the newly preserved stack frame.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/conformance/src/report.ts Adjusts stack-frame regex parsing so non-line:col frames are retained and formatted consistently.
apps/oxlint/conformance/snapshots/stylistic.md Updates snapshot output to include the previously dropped stack frame.

@overlookmotel overlookmotel self-assigned this Mar 18, 2026
This was referenced Mar 18, 2026
Merged
Merged
@overlookmotel overlookmotel marked this pull request as draft March 18, 2026 09:47
@overlookmotel overlookmotel marked this pull request as ready for review March 18, 2026 12:46
This was referenced Mar 18, 2026
Merged
Merged
Merged
Merged
Closed
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 20, 2026
@overlookmotel overlookmotel removed the 0-merge Merge with Graphite Merge Queue label Mar 20, 2026
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 20, 2026 — with Graphite App
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 20, 2026 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel overlookmotel force-pushed the om/03-15-test_linter_plugins_fix_stack_traces_in_conformance_snapshots branch from e35f7ab to e487ead Compare March 21, 2026 12:20
@overlookmotel
test(linter/plugins): fix stack traces in conformance snapshots (#20473)
608cd3c 
Fix bug in conformance test runner. It was removing some lines from stack traces where errors occur.
@graphite-app graphite-app bot force-pushed the om/03-15-test_linter_plugins_fix_stack_traces_in_conformance_snapshots branch from e487ead to 608cd3c Compare March 21, 2026 12:24
@graphite-app graphite-app bot merged commit 608cd3c into main Mar 21, 2026
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 21, 2026
@graphite-app graphite-app bot deleted the om/03-15-test_linter_plugins_fix_stack_traces_in_conformance_snapshots branch March 21, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel