Skip to content

refactor(oxlint): extract vite lint config in JS loader#20256

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-12-refactor_oxlint_extract_vite_lint_config_in_js_loader
Mar 12, 2026
Merged

refactor(oxlint): extract vite lint config in JS loader#20256
graphite-app[bot] merged 1 commit intomainfrom
03-12-refactor_oxlint_extract_vite_lint_config_in_js_loader

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Mar 12, 2026

Closes #20228

The challenge is how to communicate from JS to Rust side when we find a vite.config.ts file that doesn't have a .lint property.
For now, I've set it to return null, but please let me know if you have any better alternatives.

Copy link
Member Author

leaysgur commented Mar 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 12, 2026
@leaysgur leaysgur force-pushed the 03-12-refactor_oxlint_extract_vite_lint_config_in_js_loader branch from 63be600 to 632b54c Compare March 12, 2026 02:52
@leaysgur leaysgur force-pushed the 03-12-fix_oxlint_skip_vite.config.ts_w_o_.lint_field_in_auto-discovery branch from e58c283 to 2f76cfd Compare March 12, 2026 02:52
@leaysgur leaysgur requested a review from Copilot March 12, 2026 02:53
@leaysgur leaysgur force-pushed the 03-12-refactor_oxlint_extract_vite_lint_config_in_js_loader branch from 632b54c to 88af2b6 Compare March 12, 2026 03:02
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 12, 2026

Merge activity

Closes #20228

The challenge is how to communicate from JS to Rust side when we find a `vite.config.ts` file that doesn't have a `.lint` property.
For now, I've set it to return `null`, but please let me know if you have any better alternatives.
@graphite-app graphite-app bot force-pushed the 03-12-fix_oxlint_skip_vite.config.ts_w_o_.lint_field_in_auto-discovery branch from 2f76cfd to cc89dbf Compare March 12, 2026 04:15
@graphite-app graphite-app bot force-pushed the 03-12-refactor_oxlint_extract_vite_lint_config_in_js_loader branch from 88af2b6 to 5eb9991 Compare March 12, 2026 04:15
graphite-app bot pushed a commit that referenced this pull request Mar 12, 2026
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
Base automatically changed from 03-12-fix_oxlint_skip_vite.config.ts_w_o_.lint_field_in_auto-discovery to main March 12, 2026 04:26
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
@graphite-app graphite-app bot merged commit 5eb9991 into main Mar 12, 2026
19 of 23 checks passed
@graphite-app graphite-app bot deleted the 03-12-refactor_oxlint_extract_vite_lint_config_in_js_loader branch March 12, 2026 04:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
@leaysgur leaysgur review requested due to automatic review settings March 23, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant