Skip to content

feat(linter/no-constant-binary-expression): report errors for const >,>=,<,<= operators#19849

Closed
camc314 wants to merge 1 commit intographite-base/19849from
c/02-28-feat_linter_no-constant-binary-expression_report_errors_for_const_operators
Closed

feat(linter/no-constant-binary-expression): report errors for const >,>=,<,<= operators#19849
camc314 wants to merge 1 commit intographite-base/19849from
c/02-28-feat_linter_no-constant-binary-expression_report_errors_for_const_operators

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 28, 2026

No description provided.

@camc314 camc314 mentioned this pull request Feb 28, 2026
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Feb 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 28, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 51 skipped benchmarks1

Comparing c/02-28-feat_linter_no-constant-binary-expression_report_errors_for_const_operators (2674eb8) with c/02-28-fix_linter_correct_double-comparisons_fix_with_swapped_operands (14cbd35)

Open in CodSpeed

Footnotes

  1. 51 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot changed the base branch from c/02-28-fix_linter_correct_double-comparisons_fix_with_swapped_operands to graphite-base/19849 March 1, 2026 11:40
@camc314
Copy link
Contributor Author

camc314 commented Mar 17, 2026

will fix once the upstream eslint issue is addressed

@camc314 camc314 closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314