Skip to content

feat(oxlint/lsp)!: show/fix safe suggestions by default#19816

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default
Mar 30, 2026
Merged

feat(oxlint/lsp)!: show/fix safe suggestions by default#19816
graphite-app[bot] merged 1 commit intomainfrom
02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default

Conversation

@Sysix
Copy link
Copy Markdown
Member

@Sysix Sysix commented Feb 27, 2026

ESLint shows by default suggestions in the editor. We did not have the right architecture to difference between safe or dangerous fix / suggestions. With #19113 we know now what kind of fix this is.
This allows us now to align more with the ESLint editor experience. The last found tech dep was #19795.
This will not apply for editors which manage its own configurations like VS Code editor and IntelliJ Plugin (cc @nrayburn-tech). These editors need their own default value changed.

When using auto save source.fixAll.oxc or source.fixAll code action, or the oxc.fixAll command, the suggestions will be applied too. Because this is always in a context of one file only, I guess this is safe. Or we can change the line for this:

// Only safe fixes or suggestions are applied in "fix all" action/command.
if !FixKind::SafeFixOrSuggestion.can_apply(fixed_content.kind) {
debug!("Skipping unsafe fix for fix all action: {}", fixed_content.message);
continue;
}

Copy link
Copy Markdown
Member Author

Sysix commented Feb 27, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Feb 27, 2026
@Sysix Sysix changed the title feat!(oxlint/lsp): show/fix safe suggestions fixes by default feat!(oxlint/lsp): show/fix safe suggestions by default Feb 27, 2026
@Sysix Sysix changed the title feat!(oxlint/lsp): show/fix safe suggestions by default feat(oxlint/lsp)!: show/fix safe suggestions by default Feb 27, 2026
@github-actions github-actions Bot added the C-enhancement Category - New feature or request label Feb 27, 2026
@Sysix Sysix force-pushed the 02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default branch from 9ba7686 to 75f63c0 Compare February 27, 2026 16:51
@Sysix Sysix requested a review from Copilot February 27, 2026 16:58
@Sysix Sysix removed the A-linter-plugins Area - Linter JS plugins label Feb 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request changes the default fixKind behavior for the oxlint LSP server from SafeFix to SafeFixOrSuggestion, aligning it with ESLint's default editor experience of showing suggestions by default. This builds on recent architectural improvements that introduced the FixedContentKind enum (PR #19113) and explicit type checking for fix kinds (PR #19795), which now enable differentiating between safe and dangerous fixes/suggestions.

Changes:

  • Updated the default LintFixKindFlag enum value from SafeFix to SafeFixOrSuggestion
  • Inverted test logic to verify suggestions are shown by default and only hidden when explicitly setting fixKind to safe_fix
  • Updated snapshot tests to reflect that safe suggestions are now included in code actions and fix-all operations

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src/lsp/options.rs Changed the #[default] attribute from SafeFix to SafeFixOrSuggestion in the LintFixKindFlag enum, and updated the corresponding test assertion
apps/oxlint/test/lsp/code_action/code_action.test.ts Inverted test structure: basic tests now use default config (showing suggestions), while filtered tests explicitly set fixKind: "safe_fix" to hide suggestions
apps/oxlint/src/lsp/snapshots/*.snap Updated snapshots to reflect that code actions and fix-all operations now include safe suggestions by default (previously showed "None")

@Sysix Sysix marked this pull request as ready for review February 27, 2026 17:02
@Sysix Sysix requested a review from camc314 as a code owner February 27, 2026 17:02
@github-actions github-actions Bot added the A-linter-plugins Area - Linter JS plugins label Feb 27, 2026
@camc314 camc314 self-assigned this Feb 27, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 30, 2026
Copy link
Copy Markdown
Contributor

camc314 commented Mar 30, 2026

Merge activity

@Sysix Sysix force-pushed the 02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default branch from 75f63c0 to 020fc56 Compare March 30, 2026 18:53
@github-actions github-actions Bot added the A-editor Area - Editor and Language Server label Mar 30, 2026
@Sysix Sysix force-pushed the 02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default branch from 020fc56 to 9ebf781 Compare March 30, 2026 19:01
ESLint shows by default suggestions in the editor. We did not have the right architecture to difference between safe or dangerous fix / suggestions. With #19113 we know now what kind of fix this is.
This allows us now to align more with the ESLint editor experience. The last found tech dep was #19795.
This will not apply for editors which manage its own configurations like VS Code editor and IntelliJ Plugin (cc @nrayburn-tech). These editors need their own default value changed.

When using auto save `source.fixAll.oxc` or `source.fixAll` code action, or the `oxc.fixAll` command, the suggestions will be applied too. Because this is always in a context of one file only, I guess this is safe. Or we can change the line for this: https://github.com/oxc-project/oxc/blob/a45b9f4f808e4761ee615c31ea32bccfad322602/apps/oxlint/src/lsp/code_actions.rs#L96-L100
@graphite-app graphite-app Bot force-pushed the 02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default branch from 9ebf781 to 22ce6af Compare March 30, 2026 19:06
@graphite-app graphite-app Bot merged commit 22ce6af into main Mar 30, 2026
24 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Mar 30, 2026
@graphite-app graphite-app Bot deleted the 02-27-feat_oxlint_lsp_show_fix_safe_suggestions_fixes_by_default branch March 30, 2026 19:11
leaysgur pushed a commit that referenced this pull request Apr 7, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 22ce6af oxlint/lsp: [**BREAKING**] Show/fix safe suggestions by
default (#19816) (Sysix)

### 🚀 Features

- 7a7b7b8 oxlint/lsp: Add source.fixAllDangerous.oxc code action kind
(#20526) (bab)
- 9cfe57e linter/unicorn: Implement prefer-import-meta-properties rule
(#20662) (Irfan - ئىرفان)
- 1edb391 linter/eslint: Implement `no-restricted-exports` rule (#20592)
(Nicolas Le Cam)
- 0f12bcd linter/react: Implement `hook-use-state` rule (#20986) (Khaled
Labeb)
- 1513a9f oxlint/lsp: Show note field for lsp diagnostic (#20983)
(Sysix)
- 7fdf722 linter/unicorn: Implement `no-useless-iterator-to-array` rule
(#20945) (Mikhail Baev)
- 39c8f2c linter/jest: Implement padding-around-after-all-blocks
(#21034) (Sapphire)
- ac39e51 linter/eslint-vitest-plugin: Prefer importing vitest globals
(#20960) (Said Atrahouch)
- 0b84de1 oxlint: Support allow option for prefer-promise-reject-errors
(#20934) (camc314)
- 23db851 linter/consistent-return: Move rule from nursery to suspicious
(#20920) (camc314)
- 9a27e32 linter/no-unnecessary-type-conversion: Move rule from nursery
to suspicious (#20919) (camc314)
- 1ca7b58 linter/dot-notation: Move rule from nursery to style (#20918)
(camc314)
- 73ba81a linter/consistent-type-exports: Move rule from nursery to
style (#20917) (camc314)
- b9199b1 linter/unicorn: Implement switch-case-break-position (#20872)
(Mikhail Baev)
- 3435ff8 linter: Implements `prefer-snapshot-hint` rule in Jest and
Vitest (#20870) (Said Atrahouch)
- 98510d2 linter: Implement react/prefer-function-component (#19652)
(Connor Shea)
- 871f9d9 linter: Implement no-useless-assignment (#15466) (Zhaoting
Zhou)
- 0f01fbd linter: Implement eslint/object-shorthand (#17688) (yue)

### 🐛 Bug Fixes

- dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya
kawaguchi)
- 9bc77dd linter/no-unused-private-class-members: False positive with
await expr (#21067) (camc314)
- 60a57cd linter/const-comparisons: Detect equality contradictions
(#21065) (camc314)
- 2bb2be2 linter/no-array-index-key: False positive when index is passed
as function argument (#21012) (bab)
- 6492953 linter/no-this-in-sfc: Only flag `this` used as member
expression object (#20961) (bab)
- 9446dcc oxlint/lsp: Skip `node_modules` in oxlint config walker
(#21004) (copilot-swe-agent)
- af89923 linter/no-namespace: Support glob pattern matching against
basename (#21031) (bab)
- 64a1a7e oxlint: Don't search for nested config outside base config
(#21051) (Sysix)
- 3b953bc linter/button-has-type: Ignore `document.createElement` calls
(#21008) (Said Atrahouch)
- 8c36070 linter/unicorn: Add support for `Array.from()` for
`prefer-set-size` rule (#21016) (Mikhail Baev)
- c1a48f0 linter: Detect vitest import from vite-plus/test (#20976)
(Said Atrahouch)
- 5c32fd1 lsp: Prevent corrupted autofix output from overlapping text
edits (#19793) (Peter Wagenet)
- ca79960 linter/no-array-index-key: Move span to `key` property
(#20947) (camc314)
- 2098274 linter: Add suggestion for `jest/prefer-equality-matcher`
(#20925) (eryue0220)
- 6eb77ec linter: Allow default-import barrels in import/named (#20757)
(Bazyli Brzóska)
- 9c218ef linter/eslint-vitest-plugin: Remove pending fix status for
require-local-test-context-for-concurrent-snapshot (#20890) (Said
Atrahouch)

### ⚡ Performance

- fb52383 napi/parser, linter/plugins: Clear buffers and source texts
earlier (#21025) (overlookmotel)
- 3b7dec4 napi/parser, linter/plugins: Use `utf8Slice` for decoding
UTF-8 strings (#21022) (overlookmotel)
- 012c924 napi/parser, linter/plugins: Speed up decoding strings in raw
transfer (#21021) (overlookmotel)
- 55e1e9b napi/parser, linter/plugins: Initialize vars as 0 (#21020)
(overlookmotel)
- c25ef02 napi/parser, linter/plugins: Simplify branch condition in
`deserializeStr` (#21019) (overlookmotel)
- 9f494c3 napi/parser, linter/plugins: Raw transfer use
`String.fromCharCode` in string decoding (#21018) (overlookmotel)
- 0503a78 napi/parser, linter/plugins: Faster deserialization of `raw`
fields (#20923) (overlookmotel)
- a24f75e napi/parser: Optimize string deserialization for non-ASCII
sources (#20834) (Joshua Tuddenham)

### 📚 Documentation

- af72b80 oxlint: Fix typo for --tsconfig (#20889) (leaysgur)
- 70c53b1 linter: Highlight that tsconfig is not respected in type aware
linting (#20884) (camc314)
# Oxfmt
### 🚀 Features

- 35cf6e8 oxfmt: Add node version hint for ts config import failures
(#21046) (camc314)

### 🐛 Bug Fixes

- dd2df87 npm: Export package.json for oxlint and oxfmt (#20784) (kazuya
kawaguchi)
- 9d45511 oxfmt: Propagate file write errors instead of panicking
(#20997) (leaysgur)
- 139ddd9 formatter: Handle leading comment after array elision (#20987)
(leaysgur)
- 4216380 oxfmt: Support `.editorconfig` `tab_width` fallback (#20988)
(leaysgur)
- d10df39 formatter: Resolve pending space in fits measurer before
expanded-mode early exit (#20954) (Dunqing)
- f9ef1bd formatter: Avoid breaking after `=>` when arrow body has JSDoc
type cast (#20857) (bab)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants