fix(codegen): print static keyword for TSIndexSignature#19755
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 4, 2026
Merged
fix(codegen): print static keyword for TSIndexSignature#19755graphite-app[bot] merged 1 commit intomainfrom
static keyword for TSIndexSignature#19755graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
Merging this PR will not alter performance
Comparing 
Footnotes
|
bf4a1ae to
ed17bbf
Compare
1bb492f to
b7233d9
Compare
b7233d9 to
8cad8f5
Compare
7086d36 to
44b7ddd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the code generator (oxc_codegen) where the static modifier was not being emitted when printing TSIndexSignature nodes (e.g., static [key: string]: string in a class body). The missing keyword caused the static modifier to be silently dropped during code generation.
Changes:
- Add emission of the
statickeyword inTSIndexSignature::genbefore the existingreadonlykeyword check. - Add a
test_sameround-trip test verifying thatstatic [key: string]: stringis preserved during codegen.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/oxc_codegen/src/gen.rs |
Adds if self.r#static { p.print_str("static "); } before the readonly check in TSIndexSignature code generation, fixing the dropped modifier. |
crates/oxc_codegen/tests/integration/ts.rs |
Adds a test_same round-trip test for a class with a static index signature. |
camc314
approved these changes
Mar 4, 2026
Contributor
Merge activity
|
The codegen was missing the `static` keyword when printing `TSIndexSignature` nodes, causing `static [key: string]: string` index signatures to lose the `static` modifier during code generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
44b7ddd to
588009e
Compare
camc314
pushed a commit
that referenced
this pull request
Mar 9, 2026
### 🚀 Features - e8547cc parser: Report error for using declarations in ambient contexts (#19934) (camc314) - 8345318 allocator: Add methods for boxed slices `ArenaBox<[T]>` (#19968) (overlookmotel) - f83be30 allocator: Add `Vec::push_fast` method (#19959) (overlookmotel) ### 🐛 Bug Fixes - 291d867 transformer_plugins: Unwrap ChainExpression after define replacement removes optional markers (#20058) (IWANABETHATGUY) - 36b2e56 codegen: Print type for TSImportEqualsDeclaration (#20128) (camc314) - 5a246ec codegen: Print type arguments for JSXOpeningElement (#20127) (camc314) - a40870e codegen: Preserve parens for TSNonNullExpression (#20125) (camc314) - ae830b2 codegen: Print `declare` for `TSInterfaceDeclaration` (#20124) (camc314) - 92cfb14 linter/plugins: Fix types for `walkProgram` and `walkProgramWithCfg` (#20081) (overlookmotel) - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - 588009e codegen: Print `static` keyword for TSIndexSignature (#19755) (Dunqing) - 5a8799c codegen: Print `with_clause` for `ExportNamedDeclaration` (#20002) (Dunqing) - 7502afe parser: Correct capacity for tokens `Vec` (#19967) (overlookmotel) ### ⚡ Performance - 4ea8f9a napi: Remove `napi_build::setup()` from `oxc_napi` to avoid redundant rebuilds (#20094) (Boshen) - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) - 8ba61dd parser: Make pushing tokens faster (#19960) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen was missing the
statickeyword when printingTSIndexSignaturenodes, causing
static [key: string]: stringindex signatures to lose thestaticmodifier during code generation.Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com