test(oxfmt): Add xxx-in-js-conformance#19739
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
3 tasks
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 26, 2026
6e26e8c to
ee13d14
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the GraphQL-in-JS conformance testing from a standalone script (cmp.js) to a proper vitest test case (xxx-in-js-conformance.test.ts). This aligns the GraphQL-in-JS conformance testing with the existing test infrastructure used for other embedded language conformance tests.
Changes:
- Removed standalone
cmp.jsscript that manually compared oxfmt and Prettier outputs - Added
xxx-in-js-conformance.test.tsas a vitest test suite for GraphQL-in-JS conformance - Migrated from old fixture path to standardized
prettier-fixturesdirectory structure
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxfmt/test/api/xxx-in-js-conformance.test.ts | New vitest test suite for GraphQL-in-JS conformance testing using the standardized test infrastructure |
| apps/oxfmt/cmp.js | Removed standalone comparison script in favor of integrated test suite |
Dunqing
approved these changes
Feb 26, 2026
Contributor
Merge activity
|
Convert `cmp.js` to vitest test case.
d03d877 to
14a0181
Compare
ee13d14 to
72ce141
Compare
Base automatically changed from
02-25-feat_oxfmt_support_graphql_._for_gql-in-js
to
main
February 26, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
cmp.jsto vitest test case.