Skip to content

fix(linter): honor no-empty-function allow getters/setters for object literals#19393

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals
Feb 15, 2026
Merged

fix(linter): honor no-empty-function allow getters/setters for object literals#19393
graphite-app[bot] merged 1 commit intomainfrom
c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 14, 2026

Fixes #19391

@camc314 camc314 marked this pull request as ready for review February 14, 2026 22:44
Copilot AI review requested due to automatic review settings February 14, 2026 22:44
Copy link
Contributor Author

camc314 commented Feb 14, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 14, 2026
@camc314 camc314 changed the base branch from main to graphite-base/19393 February 14, 2026 22:47
@camc314 camc314 force-pushed the c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals branch from 5c58d19 to 3406248 Compare February 14, 2026 22:47
@camc314 camc314 changed the base branch from graphite-base/19393 to add-more-tests February 14, 2026 22:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Oxlint’s ESLint no-empty-function implementation to match ESLint behavior for object-literal getters/setters when configured via allow.

Changes:

  • Adds AstKind::ObjectProperty handling so object-literal getters/setters can be exempted by allow: ["getters"/"setters"].
  • Introduces is_allowed_object_property helper to apply allow logic for object properties.
  • Re-enables/ports previously TODO’d tests for object-literal getters/setters.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 14, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals (49e8852) with main (ffb2c06)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Base automatically changed from add-more-tests to main February 14, 2026 22:50
@camc314 camc314 force-pushed the c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals branch from 3406248 to 49e8852 Compare February 15, 2026 11:26
@camc314 camc314 self-assigned this Feb 15, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 15, 2026
Copy link
Contributor Author

camc314 commented Feb 15, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals branch from 49e8852 to 3d24e44 Compare February 15, 2026 11:54
@graphite-app graphite-app bot merged commit 3d24e44 into main Feb 15, 2026
21 checks passed
@graphite-app graphite-app bot deleted the c/02-14-fix_linter_honor_no-empty-function_allow_getters_setters_for_object_literals branch February 15, 2026 12:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 15, 2026
camc314 pushed a commit that referenced this pull request Feb 16, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report
`globalThis` by default (#19407) (Sysix)

### 🚀 Features

- ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández)
- 7a333c1 linter: Support dynamic configs via CLI arguments (#19384)
(camc314)
- 1bf569b linter: Implement typescript/unified-signatures (#19375)
(camc314)
- 6562a9b linter: Implement typescript/parameter-properties (#19374)
(camc314)
- 94d8d74 linter: Implement typescript/no-use-before-define (#19373)
(camc314)
- 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins
(#19371) (camc314)
- 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341)
(Vincent R)
- cc00a59 linter/const-comparisons: Improve diagnostics when mixing
logical/comparison operators (#19370) (camc314)
- ea2c401 linter: Add support for no constructed context values (#18067)
(Jovi De Croock)
- f2440eb linter: Mark eslint/no-return-assign as having no fixer
(#19327) (camc314)
- 8588670 linter/unicorn: Implement suggestion for
`unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev)
- f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule
out of the nursery. (#19355) (connorshea)
- be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint
diagnostics (#19201) (camchenry)
- b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326)
(camc314)
- 1612932 linter: Add typescript/no-unnecessary-condition (#19130)
(camc314)
- 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323)
(camc314)

### 🐛 Bug Fixes

- c2b1870 linter: Enforce config options for `react/forbid-dom-props`
rule. (#19387) (connorshea)
- 3d24e44 linter: Honor no-empty-function allow getters/setters for
object literals (#19393) (camc314)
- bbced8d linter: Enforce config options for `eslint/no-empty-function`
rule, improve docs. (#19390) (connorshea)
- 6bc8aec linter: Fix the behavior of `import/extensions` rule for a
file that has multiple extensions. (#18919) (connorshea)
- c62a295 linter/img-redundant-alt: Enforce whole-word matching for
redundant alt text (#19367) (camc314)
- 98956fe linter/describe-function-title: Skip autofix for type-only
imports (#19329) (camc314)
- d96d26d linter/plugins: Provide `parser.version` (#19364)
(overlookmotel)
- 81f0039 linter_codegen: Compute rule IDs relative to previous rule
(#19350) (camchenry)
- b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record
conversions for mapped types (#19320) (camc314)

### 📚 Documentation

- 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361)
(connorshea)
- b069269 linter/plugins: Add comment about deprecated `ScopeManager`
methods (#19363) (overlookmotel)
- 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation`
examples. (#19347) (connorshea)
- fb87806 linter: Ensure that we do not auto-format the docs for
`unicorn/number-literal-case` rule. (#19346) (connorshea)
- 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule
options (#19324) (camc314)
# Oxfmt
### 💥 BREAKING CHANGES

- 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups`
order (#19427) (leaysgur)
- 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group
name with renaming `side-effect` > `side_effect` (#19416) (leaysgur)

### 🚀 Features

- 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }`
inside `groups` (#19358) (leaysgur)
- d1c2fb6 formatter/sort_imports: Support `customGroups`
attributes(`selector` and `modifiers`) (#19356) (leaysgur)

### 🐛 Bug Fixes

- f084ea6 oxfmt: Explicitly pass `process.env` for the forked process
(#19380) (Long Ho)
- 2bc7a14 formatter: Arrow function body incorrectly broken when return
type has comment (#19368) (Dunqing)
- 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file
(#19353) (leaysgur)
- e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call
argument (#19348) (Dunqing)
- 80643d5 formatter: Match Prettier union indentation with leading
comments (#19271) (Dunqing)

### ⚡ Performance

- c169c77 syntax: Optimize `is_identifier_name_patched` (#19386)
(sapphi-red)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: eslint/no-empty-function behavior differs from original rule

2 participants