fix(oxlint/lsp): search parent directories for root oxlint config by Copilot · Pull Request #19062 · oxc-project/oxc

Copilot · 2026-02-06T12:27:00Z

Plan to fix root config lookup for nested workspace folders

Summary

This PR fixes the issue where the LSP extension doesn't apply the root configuration when nested workspace folders are active in VS Code.

Problem

When a VS Code workspace has multiple folders configured (common in monorepos), and some folders are nested paths like apps/app1, the LSP would only look for configuration in those nested directories, missing any root configuration.

Solution

Created a new function load_root_config_with_ancestor_search that:

Searches from the current directory up through parent directories to find a config file
Returns the first config found, or default if none found
Maintains backward compatibility by respecting explicit config paths

The LSP server now uses this function instead of load_root_config to properly handle nested workspace folders.

Changes

Added load_root_config_with_ancestor_search function in config_loader.rs
Extracted shared config loading logic into try_load_config_from_dir helper function to avoid duplication
Updated LSP server in server_linter.rs to use the new function
Added comprehensive tests to verify the functionality
Created dedicated fixture directories:
- apps/oxlint/fixtures/ancestor_search for testing ancestor search functionality
- apps/oxlint/fixtures/ancestor_search_explicit_config for testing explicit config paths
Addressed code review feedback with better error handling and proper test fixtures
Fixed CI failure by using correct relative paths in tests

Security Summary

No security vulnerabilities introduced. CodeQL analysis passed with no issues.

Original prompt

This section details on the original issue you should resolve

<issue_title>oxlint/lsp: root config not applied if nested workspace folders are active</issue_title>
<issue_description>### What version of Oxlint are you using?

extension version 1.4.3

What command did you run?

No response

What does your .oxlintrc.json config file look like?

no config

What happened?

Hi there,

if a repo has workspace settings, and folders configured, the extension is broken.

Small sample workspace settings
// vs code workspace settings
{
    "folders": [
        {
            "name": "root",
            "path": "."
        },
        {
            "name": "app1",
            "path": "apps/app1"
        },
        {
            "name": "app2",
            "path": "apps/app2"
        },
        {
            "name": "libs",
            "path": "libs"
        }
    ],
	// ...
}
The LSP tries to load a config for each of the folders, not only for root.
I tried disableNestedConfig too, but it doesn't work either.

In a large monorepo the folder settings are a common approach.</issue_description>

<agent_instructions>The load config should look up the parent directories if there is a default config too.
Create a new function besides load_root_config which will search up the parent directories.

oxc/apps/oxlint/src/config_loader.rs

Lines 401 to 433 in 2537924

pub(crate) fn load_root_config(

&self,

cwd: &Path,

config_path: Option<&PathBuf>,

) -> Result<Oxlintrc, OxcDiagnostic> {

if let Some(config_path) = config_path {

let full_path = cwd.join(config_path);

if full_path.file_name() == Some(OsStr::new(DEFAULT_TS_OXLINTRC_NAME)) {

return self.load_root_ts_config(&full_path);

}

return Oxlintrc::from_file(&full_path);

}

let json_path = cwd.join(DEFAULT_OXLINTRC_NAME);

let ts_path = cwd.join(DEFAULT_TS_OXLINTRC_NAME);

let json_exists = json_path.is_file();

let ts_exists = ts_path.is_file();

if json_exists && ts_exists {

return Err(config_conflict_diagnostic(cwd));

}

if ts_exists {

return self.load_root_ts_config(&ts_path);

}

if json_exists {

return Oxlintrc::from_file(&json_path);

}

Ok(Oxlintrc::default())

}

</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@Sysix > if a repo has workspace settings, and folders configured, the extension is broken.
Can you explain more what exactly is broken/not working?
The concept of multiple workspace folders is respected by the language server / extension.
Multiple folders can be used to manage multiple git repos too, they can have different LSP options.</comment_new>

Fixes oxlint/lsp: root config not applied if nested workspace folders are active #19061

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

apps/oxlint/src/config_loader.rs

Copilot

Pull request overview

This PR fixes an issue where the LSP extension doesn't apply root configuration files when nested workspace folders are active in VS Code (common in monorepos). The solution adds ancestor directory search functionality to find configuration files in parent directories.

Changes:

Added load_root_config_with_ancestor_search function that searches up the directory tree for config files
Extracted shared config loading logic into try_load_config_from_dir helper to avoid code duplication
Updated LSP server to use the new ancestor search function while maintaining backward compatibility with explicit config paths

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
apps/oxlint/src/config_loader.rs	Added ancestor search logic, extracted helper function for config loading, and added comprehensive tests
apps/oxlint/src/lsp/server_linter.rs	Updated to use new `load_root_config_with_ancestor_search` function instead of `load_root_config`
apps/oxlint/fixtures/ancestor_search/.oxlintrc.json	Test fixture for ancestor search functionality with `no-console` rule
apps/oxlint/fixtures/ancestor_search/apps/app1/test.js	Test file for ancestor search test case
apps/oxlint/fixtures/ancestor_search_explicit_config/.oxlintrc.json	Test fixture for explicit config path test with `no-debugger` rule

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/oxlint/src/config_loader.rs

Sysix · 2026-02-06T13:58:38Z

@copilot I broke CI, fix it please

Copilot · 2026-02-06T14:04:01Z

@copilot I broke CI, fix it please

Fixed the CI failure. The issue was that the test was using an absolute path (cwd.join(...)) when the function expects a relative path (it does the join internally). Changed to use the correct relative path fixtures/ancestor_search_explicit_config/.oxlintrc.json matching the pattern used in other tests. All 233 tests now pass. Fixed in commit 0f6f051.

camc314 · 2026-02-06T15:05:57Z

Merge activity

Feb 6, 3:05 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 6, 3:06 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 6, 3:17 PM UTC: Merged by the Graphite merge queue.

@Sysix

…9062) ## Plan to fix root config lookup for nested workspace folders - [x] Explore repository structure and understand the issue - [x] Create new function `load_root_config_with_ancestor_search` that searches up parent directories - [x] Update LSP server to use the new function - [x] Add tests for the new functionality - [x] Verify the fix works as expected with manual testing - [x] Address code review feedback - [x] Apply code formatting - [x] Create dedicated fixture directory for ancestor search test - [x] Refactor duplicated config loading logic into helper function - [x] Create dedicated fixture for explicit config path test - [x] Fix CI failure with correct path handling ## Summary This PR fixes the issue where the LSP extension doesn't apply the root configuration when nested workspace folders are active in VS Code. ### Problem When a VS Code workspace has multiple folders configured (common in monorepos), and some folders are nested paths like `apps/app1`, the LSP would only look for configuration in those nested directories, missing any root configuration. ### Solution Created a new function `load_root_config_with_ancestor_search` that: 1. Searches from the current directory up through parent directories to find a config file 2. Returns the first config found, or default if none found 3. Maintains backward compatibility by respecting explicit config paths The LSP server now uses this function instead of `load_root_config` to properly handle nested workspace folders. ### Changes - Added `load_root_config_with_ancestor_search` function in `config_loader.rs` - Extracted shared config loading logic into `try_load_config_from_dir` helper function to avoid duplication - Updated LSP server in `server_linter.rs` to use the new function - Added comprehensive tests to verify the functionality - Created dedicated fixture directories: - `apps/oxlint/fixtures/ancestor_search` for testing ancestor search functionality - `apps/oxlint/fixtures/ancestor_search_explicit_config` for testing explicit config paths - Addressed code review feedback with better error handling and proper test fixtures - Fixed CI failure by using correct relative paths in tests ### Security Summary No security vulnerabilities introduced. CodeQL analysis passed with no issues.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>oxlint/lsp: root config not applied if nested workspace folders are active</issue_title> > <issue_description>### What version of Oxlint are you using? > > extension version 1.4.3 > > ### What command did you run? > > _No response_ > > ### What does your `.oxlintrc.json` config file look like? > > no config > > ### What happened? > > Hi there, > > if a repo has workspace settings, and folders configured, the extension is broken. > > Small sample workspace settings > > ```json > // vs code workspace settings > { > "folders": [ > { > "name": "root", > "path": "." > }, > { > "name": "app1", > "path": "apps/app1" > }, > { > "name": "app2", > "path": "apps/app2" > }, > { > "name": "libs", > "path": "libs" > } > ], > // ... > } > ``` > > The LSP tries to load a config for each of the folders, not only for root. > I tried disableNestedConfig too, but it doesn't work either. > > In a large monorepo the folder settings are a common approach.</issue_description> > > <agent_instructions>The load config should look up the parent directories if there is a default config too. > Create a new function besides `load_root_config` which will search up the parent directories. > https://github.com/oxc-project/oxc/blob/25379248d19c0ee213500e119bd467299e41085c/apps/oxlint/src/config_loader.rs#L401-L433</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@Sysix</author><body> > > if a repo has workspace settings, and folders configured, the extension is broken. > > Can you explain more what exactly is broken/not working? > The concept of multiple workspace folders is respected by the language server / extension. > Multiple folders can be used to manage multiple git repos too, they can have different LSP options.</body></comment_new> > </comments> > </details>  - Fixes #19061  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/oxc-project/oxc/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

# Oxlint ### 🚀 Features - aef2af5 linter/unicorn: Add fixer for `unicorn/relative-url-style` rule (#19186) (Mikhail Baev) - 80eba6f linter/max-params: Support `countThis` option (#19175) (camc314) - e19bc45 linter/no-new-func: Improve rule diagnostic with note and actionable help message (#19132) (Sean Gallen) - e3dc5f6 linter/plugins: `RuleTester` test suggestions (#19104) (overlookmotel) - 6054249 linter/plugins: Add `recursive` option to `RuleTester` (#19093) (overlookmotel) - 27c241b linter/plugins: `RuleTester` test fixes (#19091) (overlookmotel) - 7318275 linter/new-cap: Tighten diagnostic spans and add help text (#19131) (camchenry) - ac2b16b linter: Improve `no-misleading-character-class` diagnostic spans (#19109) (Sysix) - 7be8613 linter: Move `no-misleading-chracter-class` to `correctness` (#19006) (Sysix) - 87a920d ci: Add riscv64 and s390x napi targets for oxlint and oxfmt (#19039) (Boshen) - ee2925b oxlint/lsp: Enable JS plugins (#18834) (overlookmotel) - 533013d linter/unicorn: Implement suggestion for `unicorn/prefer-dom-node-dataset` (#19051) (Mikhail Baev) - 384abae linter/oxc/no-async-endpoint-handlers: Improve diagnostic message (#19001) (camc314) - d35ece3 linter/array-callback-return: Improve diagnostic hints for some cases (#18993) (camc314) - dd0f754 linter/array-callback-return: Improve diagnostic message for `forEach` case (#18992) (camc314) - e2d28fe linter/plugins: Implement suggestions (#18963) (overlookmotel) - a398152 linter: Promote the `eslint/no-iterator` rule to correctness, which makes it a default rule (#18915) (connorshea) - bb1eb97 linter: Improve diagnostic message for circular configs (#18947) (camc314) - 3184f36 linter: Ban relative js plugin specifiers in js extends config (#18944) (camc314) - 749972f linter: Validate dynamic config extends shape (#18943) (camc314) - b270739 linter: Support extends in oxlint.config.ts (#18942) (camc314) - 6024ddf linter: Implement suggestion for `unicorn/prefer-reflect-apply` (#18932) (Mikhail Baev) - b06b3a9 linter: Implement `typescript/consistent-type-assertions` (#18869) (Bazyli Brzóska) - 9fd3bd6 linter/plugins: Add `@oxlint/plugins` NPM package (#18824) (overlookmotel) - 5ee7b2f linter/vitest: Implements `prefer-expect-type-of` rule (#17957) (Said Atrahouch) - a7b360a linter/unicorn: Implement `unicorn/relative-url-style` rule (#18857) (Mikhail Baev) - 9788a96 oxlint,oxfmt: Add more native builds (#18853) (Boshen) - b23395a linter: Enforce exporting an object with `defineConfig` (#18858) (camc314) ### 🐛 Bug Fixes - 7800fc5 linter/prefer-event-target: Ignore EventEmitter imported from packages (#19188) (camc314) - 03b2955 linter/typescript/ban-types: Mark rule as deprecated (#19179) (camc314) - a5b8766 oxlint/lsp: Disable rule for this line should not be preferred (#19083) (Sysix) - e08157e linter/jsx-filename-extension: Include filename in as-needed diagnostic (#19172) (camc314) - 1773acb oxlint: Re-generate envs (#19169) (camc314) - 51c3fc8 linter/no-array-for-each: Skip `Effect.forEach` calls (#19127) (camc314) - 825f148 linter/plugins: `RuleTester` consider adjacent fixes as overlapping in ESLint compat mode (#19094) (overlookmotel) - ecd2456 linter/plugins: Handle fix with -1 offsets in file with BOM (#19092) (overlookmotel) - 5969d26 linter/no-array-sort: Avoid false positives for effect Chunk.sort (#19125) (camc314) - de10f04 linter: `no-misleading-character-class`: do not skip reporting on first invalid sequence of the checking group (#19111) (Sysix) - 8c0ce78 linter: Scope no-misleading-character-class sequences to single character class (#19108) (copilot-swe-agent) - 879e3a0 linter: `no-misleading-character-class`: split sequences on all `CharacterSet` (#19107) (Sysix) - 2ad33cc oxlint/lsp: Search parent directories for root oxlint config (#19062) (copilot-swe-agent) - f969d5e linter/prefer-dom-node-dataset: Address some edge cases in the fixer (#19065) (camc314) - ed759d1 linter/plugins: Fix error messages for invalid suggestions (#19059) (overlookmotel) - 34851a7 linter/plugins: Error not panic if invalid fix range (#19058) (overlookmotel) - 4823b58 linter/plugins: Fix fixes in files with BOM (#19056) (overlookmotel) - 2ef405e linter/no-map-spread: Improve actionability of error message (#19007) (Artyom Alekseevich) - 56c086b parser: Add modifier ordering validation (TS1029) (#19024) (Boshen) - 6067a49 linter/jsdoc: False positive in `check-tag-names` for `@` in email addresses and npm scopes (#19021) (Boshen) - 6d46ed9 linter/capitalized-comments: Ignore prettier and oxfmt directives (#19008) (Artyom Alekseevich) - a46c878 linter/react/no-array-index-key: Look for keys in expressions (#18997) (camc314) - 7d61704 linter/prefer-at: Skip autofix for `arguments` (#18991) (camc314) - 3ebae53 linter/preserve-caught-error: Skip traversing into nested try/catch stmts (#18990) (camc314) - e94d37e linter/react/no-unknown-property: Add missing `popover` related props (#18953) (Christoph Nakazawa) - 04b0d99 linter: Normalize relative paths with `./` prefix in overrides. (#18954) (connorshea) - 57917ee parser: Parse decorators on rest parameters (#18938) (Boshen) - 07742ea linter/prefer-as-const: Implement fixer for type annotation (#18899) (camc314) - d64bfdd linter/plugins: Ensure `after` hook always runs last in rule converted for ESLint (#18904) (overlookmotel) - ec39944 linter/jsx-a11y/no-distracting-elements: Support elements option (#18892) (camc314) - f609cb6 linter/prefer-expect-type-of: Handle computed elements in fixer correctly (#18890) (camc314) - ecf11e5 linter/dynamic-config: Set `ExternalPlugin.config_dir` to fix js plugins loading (#18854) (camc314) - 01b7838 linter/plugins: Do not destroy workspaces (#18833) (overlookmotel) - dc51d6b linter: Normalize paths slashes for snapshots on windows (#18825) (camc314) - dbfdc40 linter/bad-replace-all-args: Skip extracting flags from conditional expressions (#18844) (camc314) ### ⚡ Performance - ed8c054 oxc_str: Add precomputed hash to Ident for fast HashMap lookups (#19143) (Boshen) - 18f58bd oxlint/lsp: Transform unused disable directive directly to DiagnosticReport (#19112) (Sysix) - 4ce3772 linter: Remove pointless string cloning when combining suggestions (#19075) (overlookmotel) - c417bf5 linter: Avoid allocating `Vec` when compiling `PossibleFixes` (#19074) (overlookmotel) - adb2baa linter/plugins: Avoid allocation when rule provides single suggestion (#19071) (overlookmotel) - 2537924 semantic: Optimize scope resolution with fast paths and inlining (#19029) (Boshen) ### 📚 Documentation - 6e8ef38 linter/plugins: Correct and expand JSDoc comment for `RuleTester` config (#19156) (overlookmotel) - e7ec06a linter: Improve docs for `import/max-dependencies` rule. (#19119) (connorshea) - 367f730 linter/consistent-test-filename: Escape file names fixes #19114 (#19123) (camc314) - 8753a54 linter: Rewrite the docs for the `jsx-a11y/no-redundant-roles` rule. (#19117) (connorshea) - dd44b1a linter: Fix invalid directive in example code for `import/no-nodejs-modules`. (#19115) (connorshea) - 726e273 linter/plugins: Improve JSDoc comment for `DiagnosticReport` (#19103) (overlookmotel) - 9561e7f linter/plugins: Alter JS plugins example (#18900) (overlookmotel) - 501e3b6 linter: Regenerate `config.generated.ts` (#18897) (overlookmotel) - b425a0c linter: Document jsPlugins examples (#18671) (Cameron) - df2b7fa linter: Expand settings example with reference to custom plugins (#18670) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 856a01f formatter/sort_imports: [**BREAKING**] Replace prefix match with glob pattern in `customGroups.elementNamePattern` (#19066) (leaysgur) ### 🚀 Features - 91e67f3 oxfmt/lsp: Do not refer `.gitignore` (#19206) (leaysgur) - 23c0753 oxfmt: Better Tailwind CSS intergration (#19000) (Dunqing) - 87a920d ci: Add riscv64 and s390x napi targets for oxlint and oxfmt (#19039) (Boshen) - 8536dce oxfmt: Support glob for CLI paths (#18976) (leaysgur) - 6ee2d59 oxfmt: Use `oxc_formatter` in js-in-xxx part (#18373) (leaysgur) - 9788a96 oxlint,oxfmt: Add more native builds (#18853) (Boshen) ### 🐛 Bug Fixes - 119348b oxfmt: Resolve relative -> absolute path for other usages (#19207) (leaysgur) - 5f4cf30 oxfmt: Fix relative -> absolute path resolution with refactoring (#19202) (leaysgur) - dc335d1 oxfmt: Temporarily disable the override for js-in-xxx (not ready yet) (#19043) (leaysgur) - 5ea5bda oxfmt: Handle `isSingleJsxExpressionStatementInMarkdown()` check for js-in-md (#19042) (leaysgur) - 5243307 formatter: Preserve numeric separators in number literals (#19015) (Dunqing) - 9b205b3 formatter: Fallback to formatting when package.json sorting fails (#19097) (Boshen) - b79c065 formatter: Preserve comment between callee and optional chaining operator (#19020) (Dunqing) - 01d1be1 formatter: Remove unnecessary parentheses for single-member union types (#19018) (Dunqing) - f5c7e75 formatter: Preserve parentheses around await with private field access (#19014) (Dunqing) - 5a75785 formatter: Preserve parentheses around nested sequence expressions (#19013) (Dunqing) - f39c96c oxfmt: Do not override `babel-ts` for now (#19030) (leaysgur) - 0ef11bb formatter: Add space before type annotation with leading comment (#19012) (Dunqing) - cc232e1 formatter: Keep spread with callback on same line (#18999) (Dunqing) - ef5bfab oxfmt: Workaround Node.js ThreadsafeFunction cleanup race condition (#18980) (Boshen) - d53f5c4 formatter: Require string first arg in test calls (#18935) (Dunqing) - 57917ee parser: Parse decorators on rest parameters (#18938) (Boshen) - 2db8c05 formatter: Avoid breaking generic call assignments (#18933) (Dunqing) - 1e023e1 formatter: Preserve trailing comma in mts/cts arrow generics (#18928) (Dunqing) - 7c4e558 formatter/detect_code_removal: Do not count `TemplateLiteral` content (#18848) (leaysgur) ### ⚡ Performance - 467724f oxfmt: Collect glob paths in parallel (#19209) (leaysgur) - 61e0efa oxfmt: Use RwLock instead of Mutex for TSFN handles (#18888) (Boshen) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

# Oxlint ### 🚀 Features - aef2af5 linter/unicorn: Add fixer for `unicorn/relative-url-style` rule (oxc-project#19186) (Mikhail Baev) - 80eba6f linter/max-params: Support `countThis` option (oxc-project#19175) (camc314) - e19bc45 linter/no-new-func: Improve rule diagnostic with note and actionable help message (oxc-project#19132) (Sean Gallen) - e3dc5f6 linter/plugins: `RuleTester` test suggestions (oxc-project#19104) (overlookmotel) - 6054249 linter/plugins: Add `recursive` option to `RuleTester` (oxc-project#19093) (overlookmotel) - 27c241b linter/plugins: `RuleTester` test fixes (oxc-project#19091) (overlookmotel) - 7318275 linter/new-cap: Tighten diagnostic spans and add help text (oxc-project#19131) (camchenry) - ac2b16b linter: Improve `no-misleading-character-class` diagnostic spans (oxc-project#19109) (Sysix) - 7be8613 linter: Move `no-misleading-chracter-class` to `correctness` (oxc-project#19006) (Sysix) - 87a920d ci: Add riscv64 and s390x napi targets for oxlint and oxfmt (oxc-project#19039) (Boshen) - ee2925b oxlint/lsp: Enable JS plugins (oxc-project#18834) (overlookmotel) - 533013d linter/unicorn: Implement suggestion for `unicorn/prefer-dom-node-dataset` (oxc-project#19051) (Mikhail Baev) - 384abae linter/oxc/no-async-endpoint-handlers: Improve diagnostic message (oxc-project#19001) (camc314) - d35ece3 linter/array-callback-return: Improve diagnostic hints for some cases (oxc-project#18993) (camc314) - dd0f754 linter/array-callback-return: Improve diagnostic message for `forEach` case (oxc-project#18992) (camc314) - e2d28fe linter/plugins: Implement suggestions (oxc-project#18963) (overlookmotel) - a398152 linter: Promote the `eslint/no-iterator` rule to correctness, which makes it a default rule (oxc-project#18915) (connorshea) - bb1eb97 linter: Improve diagnostic message for circular configs (oxc-project#18947) (camc314) - 3184f36 linter: Ban relative js plugin specifiers in js extends config (oxc-project#18944) (camc314) - 749972f linter: Validate dynamic config extends shape (oxc-project#18943) (camc314) - b270739 linter: Support extends in oxlint.config.ts (oxc-project#18942) (camc314) - 6024ddf linter: Implement suggestion for `unicorn/prefer-reflect-apply` (oxc-project#18932) (Mikhail Baev) - b06b3a9 linter: Implement `typescript/consistent-type-assertions` (oxc-project#18869) (Bazyli Brzóska) - 9fd3bd6 linter/plugins: Add `@oxlint/plugins` NPM package (oxc-project#18824) (overlookmotel) - 5ee7b2f linter/vitest: Implements `prefer-expect-type-of` rule (oxc-project#17957) (Said Atrahouch) - a7b360a linter/unicorn: Implement `unicorn/relative-url-style` rule (oxc-project#18857) (Mikhail Baev) - 9788a96 oxlint,oxfmt: Add more native builds (oxc-project#18853) (Boshen) - b23395a linter: Enforce exporting an object with `defineConfig` (oxc-project#18858) (camc314) ### 🐛 Bug Fixes - 7800fc5 linter/prefer-event-target: Ignore EventEmitter imported from packages (oxc-project#19188) (camc314) - 03b2955 linter/typescript/ban-types: Mark rule as deprecated (oxc-project#19179) (camc314) - a5b8766 oxlint/lsp: Disable rule for this line should not be preferred (oxc-project#19083) (Sysix) - e08157e linter/jsx-filename-extension: Include filename in as-needed diagnostic (oxc-project#19172) (camc314) - 1773acb oxlint: Re-generate envs (oxc-project#19169) (camc314) - 51c3fc8 linter/no-array-for-each: Skip `Effect.forEach` calls (oxc-project#19127) (camc314) - 825f148 linter/plugins: `RuleTester` consider adjacent fixes as overlapping in ESLint compat mode (oxc-project#19094) (overlookmotel) - ecd2456 linter/plugins: Handle fix with -1 offsets in file with BOM (oxc-project#19092) (overlookmotel) - 5969d26 linter/no-array-sort: Avoid false positives for effect Chunk.sort (oxc-project#19125) (camc314) - de10f04 linter: `no-misleading-character-class`: do not skip reporting on first invalid sequence of the checking group (oxc-project#19111) (Sysix) - 8c0ce78 linter: Scope no-misleading-character-class sequences to single character class (oxc-project#19108) (copilot-swe-agent) - 879e3a0 linter: `no-misleading-character-class`: split sequences on all `CharacterSet` (oxc-project#19107) (Sysix) - 2ad33cc oxlint/lsp: Search parent directories for root oxlint config (oxc-project#19062) (copilot-swe-agent) - f969d5e linter/prefer-dom-node-dataset: Address some edge cases in the fixer (oxc-project#19065) (camc314) - ed759d1 linter/plugins: Fix error messages for invalid suggestions (oxc-project#19059) (overlookmotel) - 34851a7 linter/plugins: Error not panic if invalid fix range (oxc-project#19058) (overlookmotel) - 4823b58 linter/plugins: Fix fixes in files with BOM (oxc-project#19056) (overlookmotel) - 2ef405e linter/no-map-spread: Improve actionability of error message (oxc-project#19007) (Artyom Alekseevich) - 56c086b parser: Add modifier ordering validation (TS1029) (oxc-project#19024) (Boshen) - 6067a49 linter/jsdoc: False positive in `check-tag-names` for `@` in email addresses and npm scopes (oxc-project#19021) (Boshen) - 6d46ed9 linter/capitalized-comments: Ignore prettier and oxfmt directives (oxc-project#19008) (Artyom Alekseevich) - a46c878 linter/react/no-array-index-key: Look for keys in expressions (oxc-project#18997) (camc314) - 7d61704 linter/prefer-at: Skip autofix for `arguments` (oxc-project#18991) (camc314) - 3ebae53 linter/preserve-caught-error: Skip traversing into nested try/catch stmts (oxc-project#18990) (camc314) - e94d37e linter/react/no-unknown-property: Add missing `popover` related props (oxc-project#18953) (Christoph Nakazawa) - 04b0d99 linter: Normalize relative paths with `./` prefix in overrides. (oxc-project#18954) (connorshea) - 57917ee parser: Parse decorators on rest parameters (oxc-project#18938) (Boshen) - 07742ea linter/prefer-as-const: Implement fixer for type annotation (oxc-project#18899) (camc314) - d64bfdd linter/plugins: Ensure `after` hook always runs last in rule converted for ESLint (oxc-project#18904) (overlookmotel) - ec39944 linter/jsx-a11y/no-distracting-elements: Support elements option (oxc-project#18892) (camc314) - f609cb6 linter/prefer-expect-type-of: Handle computed elements in fixer correctly (oxc-project#18890) (camc314) - ecf11e5 linter/dynamic-config: Set `ExternalPlugin.config_dir` to fix js plugins loading (oxc-project#18854) (camc314) - 01b7838 linter/plugins: Do not destroy workspaces (oxc-project#18833) (overlookmotel) - dc51d6b linter: Normalize paths slashes for snapshots on windows (oxc-project#18825) (camc314) - dbfdc40 linter/bad-replace-all-args: Skip extracting flags from conditional expressions (oxc-project#18844) (camc314) ### ⚡ Performance - ed8c054 oxc_str: Add precomputed hash to Ident for fast HashMap lookups (oxc-project#19143) (Boshen) - 18f58bd oxlint/lsp: Transform unused disable directive directly to DiagnosticReport (oxc-project#19112) (Sysix) - 4ce3772 linter: Remove pointless string cloning when combining suggestions (oxc-project#19075) (overlookmotel) - c417bf5 linter: Avoid allocating `Vec` when compiling `PossibleFixes` (oxc-project#19074) (overlookmotel) - adb2baa linter/plugins: Avoid allocation when rule provides single suggestion (oxc-project#19071) (overlookmotel) - 2537924 semantic: Optimize scope resolution with fast paths and inlining (oxc-project#19029) (Boshen) ### 📚 Documentation - 6e8ef38 linter/plugins: Correct and expand JSDoc comment for `RuleTester` config (oxc-project#19156) (overlookmotel) - e7ec06a linter: Improve docs for `import/max-dependencies` rule. (oxc-project#19119) (connorshea) - 367f730 linter/consistent-test-filename: Escape file names fixes oxc-project#19114 (oxc-project#19123) (camc314) - 8753a54 linter: Rewrite the docs for the `jsx-a11y/no-redundant-roles` rule. (oxc-project#19117) (connorshea) - dd44b1a linter: Fix invalid directive in example code for `import/no-nodejs-modules`. (oxc-project#19115) (connorshea) - 726e273 linter/plugins: Improve JSDoc comment for `DiagnosticReport` (oxc-project#19103) (overlookmotel) - 9561e7f linter/plugins: Alter JS plugins example (oxc-project#18900) (overlookmotel) - 501e3b6 linter: Regenerate `config.generated.ts` (oxc-project#18897) (overlookmotel) - b425a0c linter: Document jsPlugins examples (oxc-project#18671) (Cameron) - df2b7fa linter: Expand settings example with reference to custom plugins (oxc-project#18670) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 856a01f formatter/sort_imports: [**BREAKING**] Replace prefix match with glob pattern in `customGroups.elementNamePattern` (oxc-project#19066) (leaysgur) ### 🚀 Features - 91e67f3 oxfmt/lsp: Do not refer `.gitignore` (oxc-project#19206) (leaysgur) - 23c0753 oxfmt: Better Tailwind CSS intergration (oxc-project#19000) (Dunqing) - 87a920d ci: Add riscv64 and s390x napi targets for oxlint and oxfmt (oxc-project#19039) (Boshen) - 8536dce oxfmt: Support glob for CLI paths (oxc-project#18976) (leaysgur) - 6ee2d59 oxfmt: Use `oxc_formatter` in js-in-xxx part (oxc-project#18373) (leaysgur) - 9788a96 oxlint,oxfmt: Add more native builds (oxc-project#18853) (Boshen) ### 🐛 Bug Fixes - 119348b oxfmt: Resolve relative -> absolute path for other usages (oxc-project#19207) (leaysgur) - 5f4cf30 oxfmt: Fix relative -> absolute path resolution with refactoring (oxc-project#19202) (leaysgur) - dc335d1 oxfmt: Temporarily disable the override for js-in-xxx (not ready yet) (oxc-project#19043) (leaysgur) - 5ea5bda oxfmt: Handle `isSingleJsxExpressionStatementInMarkdown()` check for js-in-md (oxc-project#19042) (leaysgur) - 5243307 formatter: Preserve numeric separators in number literals (oxc-project#19015) (Dunqing) - 9b205b3 formatter: Fallback to formatting when package.json sorting fails (oxc-project#19097) (Boshen) - b79c065 formatter: Preserve comment between callee and optional chaining operator (oxc-project#19020) (Dunqing) - 01d1be1 formatter: Remove unnecessary parentheses for single-member union types (oxc-project#19018) (Dunqing) - f5c7e75 formatter: Preserve parentheses around await with private field access (oxc-project#19014) (Dunqing) - 5a75785 formatter: Preserve parentheses around nested sequence expressions (oxc-project#19013) (Dunqing) - f39c96c oxfmt: Do not override `babel-ts` for now (oxc-project#19030) (leaysgur) - 0ef11bb formatter: Add space before type annotation with leading comment (oxc-project#19012) (Dunqing) - cc232e1 formatter: Keep spread with callback on same line (oxc-project#18999) (Dunqing) - ef5bfab oxfmt: Workaround Node.js ThreadsafeFunction cleanup race condition (oxc-project#18980) (Boshen) - d53f5c4 formatter: Require string first arg in test calls (oxc-project#18935) (Dunqing) - 57917ee parser: Parse decorators on rest parameters (oxc-project#18938) (Boshen) - 2db8c05 formatter: Avoid breaking generic call assignments (oxc-project#18933) (Dunqing) - 1e023e1 formatter: Preserve trailing comma in mts/cts arrow generics (oxc-project#18928) (Dunqing) - 7c4e558 formatter/detect_code_removal: Do not count `TemplateLiteral` content (oxc-project#18848) (leaysgur) ### ⚡ Performance - 467724f oxfmt: Collect glob paths in parallel (oxc-project#19209) (leaysgur) - 61e0efa oxfmt: Use RwLock instead of Mutex for TSFN handles (oxc-project#18888) (Boshen) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

Copilot AI assigned Copilot and Sysix Feb 6, 2026

Copilot started work on behalf of Sysix February 6, 2026 12:27 View session

Sysix reviewed Feb 6, 2026

View reviewed changes

apps/oxlint/src/config_loader.rs Outdated Show resolved Hide resolved

Copilot AI changed the title ~~[WIP] Fix root config not applied for nested workspace folders~~ Fix LSP config lookup for nested workspace folders Feb 6, 2026

Copilot AI requested a review from Sysix February 6, 2026 12:40

Copilot finished work on behalf of Sysix February 6, 2026 12:40

Copilot started work on behalf of Sysix February 6, 2026 12:40 View session

Copilot finished work on behalf of Sysix February 6, 2026 12:45

Sysix reviewed Feb 6, 2026

View reviewed changes

apps/oxlint/src/config_loader.rs Outdated Show resolved Hide resolved

Copilot started work on behalf of Sysix February 6, 2026 12:50 View session

Sysix changed the title ~~Fix LSP config lookup for nested workspace folders~~ fix(oxlint/lsp): search parent directories for root oxlint config Feb 6, 2026

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-bug Category - Bug labels Feb 6, 2026

Copilot AI requested a review from Sysix February 6, 2026 12:55

Copilot finished work on behalf of Sysix February 6, 2026 12:55

Sysix reviewed Feb 6, 2026

View reviewed changes

apps/oxlint/src/config_loader.rs Outdated Show resolved Hide resolved

Copilot started work on behalf of Sysix February 6, 2026 12:59 View session

Copilot AI requested a review from Sysix February 6, 2026 13:05

Copilot finished work on behalf of Sysix February 6, 2026 13:05

Sysix marked this pull request as ready for review February 6, 2026 13:14

Sysix requested a review from camc314 as a code owner February 6, 2026 13:14

Copilot AI review requested due to automatic review settings February 6, 2026 13:14

Sysix approved these changes Feb 6, 2026

View reviewed changes

Copilot started reviewing on behalf of Sysix February 6, 2026 13:15 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

apps/oxlint/src/config_loader.rs Show resolved Hide resolved

Sysix reviewed Feb 6, 2026

View reviewed changes

apps/oxlint/src/config_loader.rs Show resolved Hide resolved

Copilot started work on behalf of Sysix February 6, 2026 13:59 View session

Copilot AI requested a review from Sysix February 6, 2026 14:04

Copilot finished work on behalf of Sysix February 6, 2026 14:04

Sysix assigned camc314 and unassigned Sysix and Copilot Feb 6, 2026

Sysix approved these changes Feb 6, 2026

View reviewed changes

camc314 approved these changes Feb 6, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 6, 2026

graphite-app bot force-pushed the copilot/fix-nested-workspace-config branch from 0f6f051 to 2ad33cc Compare February 6, 2026 15:10

graphite-app bot merged commit 2ad33cc into main Feb 6, 2026
19 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 6, 2026

graphite-app bot deleted the copilot/fix-nested-workspace-config branch February 6, 2026 15:17

This was referenced Feb 9, 2026

release(apps): oxlint v1.44.0 && oxfmt v0.29.0 #19168

Closed

release(apps): oxlint v1.44.0 && oxfmt v0.29.0 #19211

Merged

This was referenced Feb 10, 2026

release(apps): oxlint v1.44.0 && oxfmt v0.29.0 #19216

Closed

release(apps): oxlint v1.44.0 && oxfmt v0.29.0 #19222

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(oxlint/lsp): search parent directories for root oxlint config#19062

fix(oxlint/lsp): search parent directories for root oxlint config#19062
graphite-app[bot] merged 1 commit intomainfrom
copilot/fix-nested-workspace-config

Copilot AI commented Feb 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Sysix commented Feb 6, 2026

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

camc314 commented Feb 6, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	pub(crate) fn load_root_config(
	&self,
	cwd: &Path,
	config_path: Option<&PathBuf>,
	) -> Result<Oxlintrc, OxcDiagnostic> {
	if let Some(config_path) = config_path {
	let full_path = cwd.join(config_path);
	if full_path.file_name() == Some(OsStr::new(DEFAULT_TS_OXLINTRC_NAME)) {
	return self.load_root_ts_config(&full_path);
	}
	return Oxlintrc::from_file(&full_path);
	}

	let json_path = cwd.join(DEFAULT_OXLINTRC_NAME);
	let ts_path = cwd.join(DEFAULT_TS_OXLINTRC_NAME);

	let json_exists = json_path.is_file();
	let ts_exists = ts_path.is_file();

	if json_exists && ts_exists {
	return Err(config_conflict_diagnostic(cwd));
	}

	if ts_exists {
	return self.load_root_ts_config(&ts_path);
	}

	if json_exists {
	return Oxlintrc::from_file(&json_path);
	}

	Ok(Oxlintrc::default())
	}

Uh oh!

Conversation

Copilot AI commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan to fix root config lookup for nested workspace folders

Summary

Problem

Solution

Changes

Security Summary

What command did you run?

What does your .oxlintrc.json config file look like?

What happened?

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Sysix commented Feb 6, 2026

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

camc314 commented Feb 6, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Feb 6, 2026 •

edited

Loading

What does your `.oxlintrc.json` config file look like?

camc314 commented Feb 6, 2026 •

edited by graphite-app bot

Loading