refactor(linter/plugins): remove deprecated exports from index entry point#18828
Merged
graphite-app[bot] merged 1 commit intoFeb 3, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated re-exports of definePlugin, defineRule, and RuleTester from the main oxlint package entry point (index.ts). The goal is to make importing defineConfig from the main entry point lightweight, avoiding the eager loading of approximately 20,000 lines of plugins-related JavaScript code.
Changes:
- Removed deprecated exports from
apps/oxlint/src-js/index.tsthat redirected to plugin-specific modules - These functions remain available from their proper locations:
definePluginanddefineRulefromoxlint/plugins(or@oxlint/plugins), andRuleTesterfromoxlint/plugins-dev
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5504055 to
74ad0f7
Compare
camc314
approved these changes
Feb 2, 2026
3d8c84d to
c0d26c7
Compare
74ad0f7 to
76d5efd
Compare
76d5efd to
96372ff
Compare
camc314
approved these changes
Feb 3, 2026
Contributor
Merge activity
|
…y point (#18828) Remove re-exports of `definePlugin`, `defineRule` and `RuleTester` from main `index` entry point of `oxlint` package. We want this to be cheap: ```js import { defineConfig } from "oxlint"; ``` But with the deprecated exports, this would eagerly load ~20,000 lines of JS plugins-related code. See `index.js` in `dist` directory before and after this PR in release build. It was the import from `./lint.js` which was massive. Personally, I don't think we need to keep the deprecated exports, for 3 reasons: 1. We have very clearly said that JS plugins are experimental and that breaking changes are very possible. 2. Given how broken our types are at present, probably few people were using `definePlugin` and `defineRule` anyway! 3. The fix for users who do get broken is trivial: ```diff - import { definePlugin } from "oxlint"; + import { definePlugin } from "@oxlint/plugins"; ```
96372ff to
b7416d0
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Continuation of #18824, #18828, #18903. Remove the `oxlint/plugins` export and the `plugins.ts` entry point. These are now only used in tests, where the files can be loaded from `dist-pkg-plugins` instead. We don't want to encourage people to use `oxlint/plugins` in their plugins - they should be using `@oxlint/plugins` package instead to avoid their plugin having a dependency on `oxlint`. Due to less shared dependencies between files, this results in 5 less files in `dist` directory in release build. This also allows re-enabling the debug assertions in this code in tests.
stickerdaniel
added a commit
to stickerdaniel/saas-starter
that referenced
this pull request
May 1, 2026
- Patch oxlint-plugin-convex@0.1.1 to import definePlugin/defineRule from @oxlint/plugins (oxlint moved them out of its main entry point starting in 1.45 — see oxc-project/oxc#18828) - Drop resolve('#') in team-two.svelte; sveltekit 2.58 made resolve() strict and rejects non-absolute paths (sveltejs/kit#15733) - Ignore varlock-generated env types in eslint (varlock 0.9 emits @ts-nocheck, tripping ban-ts-comment) - Drop now-stale eslint-disable directives surfaced by typescript-eslint See also: juliusmarminge/agent-tools#26
stickerdaniel
added a commit
to stickerdaniel/saas-starter
that referenced
this pull request
May 1, 2026
* fix(deps): update all non-major dependencies * fix(deps): unblock CI on oxlint 1.45+ and sveltekit 2.58 - Patch oxlint-plugin-convex@0.1.1 to import definePlugin/defineRule from @oxlint/plugins (oxlint moved them out of its main entry point starting in 1.45 — see oxc-project/oxc#18828) - Drop resolve('#') in team-two.svelte; sveltekit 2.58 made resolve() strict and rejects non-absolute paths (sveltejs/kit#15733) - Ignore varlock-generated env types in eslint (varlock 0.9 emits @ts-nocheck, tripping ban-ts-comment) - Drop now-stale eslint-disable directives surfaced by typescript-eslint See also: juliusmarminge/agent-tools#26 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Sticker <daniel.sticker@rwth-aachen.de>
stickerdaniel
added a commit
to stickerdaniel/saas-starter
that referenced
this pull request
Jun 3, 2026
* fix(deps): update all non-major dependencies * fix(deps): unblock CI on oxlint 1.45+ and sveltekit 2.58 - Patch oxlint-plugin-convex@0.1.1 to import definePlugin/defineRule from @oxlint/plugins (oxlint moved them out of its main entry point starting in 1.45 — see oxc-project/oxc#18828) - Drop resolve('#') in team-two.svelte; sveltekit 2.58 made resolve() strict and rejects non-absolute paths (sveltejs/kit#15733) - Ignore varlock-generated env types in eslint (varlock 0.9 emits @ts-nocheck, tripping ban-ts-comment) - Drop now-stale eslint-disable directives surfaced by typescript-eslint See also: juliusmarminge/agent-tools#26 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Sticker <daniel.sticker@rwth-aachen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove re-exports of
definePlugin,defineRuleandRuleTesterfrom mainindexentry point ofoxlintpackage.We want this to be cheap:
But with the deprecated exports, this would eagerly load ~20,000 lines of JS plugins-related code. See
index.jsindistdirectory before and after this PR in release build. It was the import from./lint.jswhich was massive.Personally, I don't think we need to keep the deprecated exports, for 3 reasons:
definePluginanddefineRuleanyway!