refactor(linter/plugins): remove Workspace and WorkspaceIdentifier types#18757
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 31, 2026
Conversation
This was referenced Jan 31, 2026
Member
Author
This was referenced Jan 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Workspace and WorkspaceIdentifier TypeScript type aliases (both previously string) and replaces their usage with plain string workspace IDs across the JS plugin workspace, options, and plugin-loading modules.
Changes:
- Delete
WorkspaceIdentifier/Workspacetype exports fromworkspace/index.ts - Update workspace tracking and public workspace functions to use
string - Update plugin options and plugin registry maps to use
stringkeys and remove now-unused type imports
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/workspace/index.ts | Removes workspace alias types; uses string for workspace IDs and internal workspace set. |
| apps/oxlint/src-js/plugins/options.ts | Replaces Map<WorkspaceIdentifier, …> with Map<string, …>; removes unused type import. |
| apps/oxlint/src-js/plugins/load.ts | Replaces Map<WorkspaceIdentifier, …> with Map<string, …>; removes unused type import and updates workspace-related APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
96b68e3 to
7dbaf0f
Compare
d131a9e to
a352061
Compare
7dbaf0f to
38e069f
Compare
a352061 to
0ada537
Compare
camc314
approved these changes
Jan 31, 2026
Contributor
camc314
left a comment
There was a problem hiding this comment.
lets consider moving these to branded strings in the future
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
…` types (#18757) Pure refactor. Remove these 2 types which were both just aliases for `string`. In Rust type wrappers can be useful (e.g. `ScopeId`) but in TS they don't add type safety, and IMO make the code less readable.
38e069f to
3ea3ea1
Compare
Base automatically changed from
om/01-31-feat_linter_plugins_ruletester_take_cwd_property
to
main
January 31, 2026 15:48
3ea3ea1 to
73a6926
Compare
…` types (#18757) Pure refactor. Remove these 2 types which were both just aliases for `string`. In Rust type wrappers can be useful (e.g. `ScopeId`) but in TS they don't add type safety, and IMO make the code less readable.
73a6926 to
6c5a09f
Compare
Member
Author
Is that possible to do in TypeScript? |
Contributor
|
yes 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Remove these 2 types which were both just aliases for
string.In Rust type wrappers can be useful (e.g.
ScopeId) but in TS they don't add type safety, and IMO make the code less readable.