feat(oxc_allocator)!: remove dangerous Allocator methods#18715
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes several unsafe and dangerous methods from the Allocator that were previously required to support writing source text at the start of allocator chunks. Following PR #18714, which eliminated the need for source text to be at the start of chunks, these methods are no longer necessary and can be safely removed.
Changes:
- Removed
alloc_bytes_startmethod that allocated space at the start of a chunk (highly dangerous, required manual drop) - Removed
data_ptrandset_data_ptrmethods that manipulated the data pointer (could cause UB if misused) - Removed
cursor_ptrhelper method that retrieved the cursor pointer - Removed
chunk_footerhelper method that retrieved an immutable reference to the chunk footer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
71058c7 to
2c6c42b
Compare
b2cdab5 to
b91f07f
Compare
Member
Author
Merge activity
|
Remove several unsafe and potentially dangerous methods from `Allocator`. These methods were only required in order to support writing source text into start of allocator chunk, instead of bumping downwards in the usual way. #18714 has removed the need for source text to be at start of allocator chunks, so we can now remove these methods. This is a breaking change, but the docs stated that use of these methods was inadvisable, so hopefully no-one is depending on them. https://github.com/oxc-project/oxc/blob/b82faec35c486c0fcdb8a242a626554d2c99a310/crates/oxc_allocator/src/lib.rs#L24-L25
2c6c42b to
e39a983
Compare
b91f07f to
445cb1a
Compare
Base automatically changed from
om/01-29-refactor_linter_plugins_store_source_text_in_end_of_buffer
to
main
January 30, 2026 00:58
This was referenced Feb 2, 2026
camc314
added a commit
that referenced
this pull request
Feb 2, 2026
### 💥 BREAKING CHANGES - 445cb1a oxc_allocator: [**BREAKING**] Remove dangerous `Allocator` methods (#18715) (overlookmotel) ### 🚀 Features - 8670b18 parser: Error on ambient class accessor implementations (#18592) (camc314) ### 🐛 Bug Fixes - 2e34461 minifier: Prevent expression inlining into block-scoped for-in declarations (#18651) (copilot-swe-agent) ### 📚 Documentation - 3d01fa1 transformer: Update links to use Oxc docs (#18722) (sapphi-red) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove several unsafe and potentially dangerous methods from
Allocator. These methods were only required in order to support writing source text into start of allocator chunk, instead of bumping downwards in the usual way.#18714 has removed the need for source text to be at start of allocator chunks, so we can now remove these methods.
This is a breaking change, but the docs stated that use of these methods was inadvisable, so hopefully no-one is depending on them.
oxc/crates/oxc_allocator/src/lib.rs
Lines 24 to 25 in b82faec