Skip to content

refactor(oxfmt): Ensure to destroy worker pool before exit#18689

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-29-refactor_oxfmt_ensure_to_destroy_worker_pool_before_exit
Jan 29, 2026
Merged

refactor(oxfmt): Ensure to destroy worker pool before exit#18689
graphite-app[bot] merged 1 commit intomainfrom
01-29-refactor_oxfmt_ensure_to_destroy_worker_pool_before_exit

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Jan 29, 2026

In most cases, it should be fine, but this approach is cleaner.

Copy link
Member Author

leaysgur commented Jan 29, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 29, 2026
@leaysgur leaysgur requested a review from Dunqing January 29, 2026 07:09
@leaysgur leaysgur force-pushed the 01-29-fix_formatter_oxfmt_handle_crlf_with_embedded_formatting branch from a57164f to c24354b Compare January 29, 2026 08:15
@leaysgur leaysgur force-pushed the 01-29-refactor_oxfmt_ensure_to_destroy_worker_pool_before_exit branch from 96c5530 to f7faf4f Compare January 29, 2026 08:15
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jan 29, 2026
Copy link
Member Author

leaysgur commented Jan 29, 2026

Merge activity

  • Jan 29, 8:18 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 29, 8:39 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jan 29, 8:46 AM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Jan 29, 8:52 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 01-29-fix_formatter_oxfmt_handle_crlf_with_embedded_formatting to graphite-base/18689 January 29, 2026 08:32
@leaysgur leaysgur force-pushed the graphite-base/18689 branch from c24354b to c3d05c1 Compare January 29, 2026 08:39
@leaysgur leaysgur force-pushed the 01-29-refactor_oxfmt_ensure_to_destroy_worker_pool_before_exit branch from f7faf4f to 65f5420 Compare January 29, 2026 08:39
@graphite-app graphite-app bot changed the base branch from graphite-base/18689 to main January 29, 2026 08:39
In most cases, it should be fine, but this approach is cleaner.
@graphite-app graphite-app bot force-pushed the 01-29-refactor_oxfmt_ensure_to_destroy_worker_pool_before_exit branch from 65f5420 to f38986e Compare January 29, 2026 08:46
@graphite-app graphite-app bot merged commit f38986e into main Jan 29, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 01-29-refactor_oxfmt_ensure_to_destroy_worker_pool_before_exit branch January 29, 2026 08:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants