Skip to content

refactor(semantic): move code into if block#18294

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-20-refactor_semantic_move_code_into_if_block
Jan 21, 2026
Merged

refactor(semantic): move code into if block#18294
graphite-app[bot] merged 1 commit intomainfrom
om/01-20-refactor_semantic_move_code_into_if_block

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 20, 2026 •
edited
Loading

Pure refactor. Move calculating includes into the if block, since it's only used in that block.

@github-actions github-actions bot added the A-semantic Area - Semantic label Jan 20, 2026
@overlookmotel overlookmotel mentioned this pull request Jan 20, 2026
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 20, 2026
This was referenced Jan 20, 2026
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Jan 20, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Jan 20, 2026
Merged
@overlookmotel overlookmotel marked this pull request as ready for review January 20, 2026 12:47
Copilot AI review requested due to automatic review settings January 20, 2026 12:47
Copilot AI reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request performs a pure refactor to improve code organization by moving the includes variable declaration into the if let Some(ident) block where it's actually used.

Changes:

  • Move includes variable calculation from outside to inside the if let Some(ident) block in the Function binder implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing om/01-20-refactor_semantic_move_code_into_if_block (7853545) with om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_ (a98ef27)

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This was referenced Jan 20, 2026
Closed
Merged
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 20, 2026
@Boshen Graphite App
Copy link
Member

Boshen commented Jan 20, 2026 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_ branch from a98ef27 to 948e0a7 Compare January 20, 2026 14:11
graphite-app bot pushed a commit that referenced this pull request Jan 20, 2026
@overlookmotel
refactor(semantic): move code into if block (#18294)
3fe7a96 
Pure refactor. Move calculating `includes` into the `if` block, since it's only used in that block.
@graphite-app graphite-app bot force-pushed the om/01-20-refactor_semantic_move_code_into_if_block branch from 7853545 to 3fe7a96 Compare January 20, 2026 14:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 20, 2026
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 21, 2026
@overlookmotel
refactor(semantic): move code into if block (#18294)
7abffcc 
Pure refactor. Move calculating `includes` into the `if` block, since it's only used in that block.
@graphite-app graphite-app bot force-pushed the om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_ branch from 948e0a7 to 6b600c4 Compare January 21, 2026 02:03
@graphite-app graphite-app bot force-pushed the om/01-20-refactor_semantic_move_code_into_if_block branch from 3fe7a96 to 7abffcc Compare January 21, 2026 02:04
Base automatically changed from om/01-20-perf_semantic_skip_parent_lookup_for_function_declarations_in_function_bind_ to main January 21, 2026 02:09
@graphite-app graphite-app bot merged commit 7abffcc into main Jan 21, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/01-20-refactor_semantic_move_code_into_if_block branch January 21, 2026 02:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Dunqing Dunqing Dunqing approved these changes

Assignees

@Dunqing Dunqing

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@overlookmotel @Boshen @Dunqing