refactor(linter/no-control-regex): move help text to character spans#17861
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing Footnotes
|
510bf23 to
80c14d2
Compare
f74562d to
9281247
Compare
80c14d2 to
a7e8cd5
Compare
Merge activity
|
…17861) Moving the help text to the actual spans makes it easier to see what code is actually being referenced. GitHub doesn't render the `.snap` file since it's detected as binary, so here's a sample of the new output: ``` ⚠ eslint(no-control-regex): Unexpected control character ╭─[no_control_regex.tsx:1:14] 1 │ var regex = /\x1f/ · ──┬─ · ╰── 'U+001F' is a control character. ╰──── ⚠ eslint(no-control-regex): Unexpected control characters ╭─[no_control_regex.tsx:1:2] 1 │ /\0\1\2/ · ─┬─┬─┬ · │ │ ╰── '\2' is a control character. It looks like a backreference, but there is no corresponding capture group. · │ ╰── '\1' is a control character. It looks like a backreference, but there is no corresponding capture group. · ╰── '\0' matches the null character (U+0000), which is a control character. ╰──── ⚠ eslint(no-control-regex): Unexpected control characters ╭─[no_control_regex.tsx:1:2] 1 │ /\x1f\0/ · ──┬──┬ · │ ╰── '\0' matches the null character (U+0000), which is a control character. · ╰── 'U+001F' is a control character. ╰──── ```
9281247 to
6c56c95
Compare
a7e8cd5 to
7365e5c
Compare

Moving the help text to the actual spans makes it easier to see what code is actually being referenced.
GitHub doesn't render the
.snapfile since it's detected as binary, so here's a sample of the new output: