Skip to content

refactor(linter/no-control-regex): move help text to character spans#17861

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans
Jan 11, 2026
Merged

refactor(linter/no-control-regex): move help text to character spans#17861
graphite-app[bot] merged 1 commit intomainfrom
01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Jan 11, 2026

Moving the help text to the actual spans makes it easier to see what code is actually being referenced.

GitHub doesn't render the .snap file since it's detected as binary, so here's a sample of the new output:

  ⚠ eslint(no-control-regex): Unexpected control character
   ╭─[no_control_regex.tsx:1:14]
 1 │ var regex = /\x1f/
   ·              ──┬─
   ·                ╰── 'U+001F' is a control character.
   ╰────

  ⚠ eslint(no-control-regex): Unexpected control characters
   ╭─[no_control_regex.tsx:1:2]
 1 │ /\0\1\2/
   ·  ─┬─┬─┬
   ·   │ │ ╰── '\2' is a control character. It looks like a backreference, but there is no corresponding capture group.
   ·   │ ╰── '\1' is a control character. It looks like a backreference, but there is no corresponding capture group.
   ·   ╰── '\0' matches the null character (U+0000), which is a control character.
   ╰────

  ⚠ eslint(no-control-regex): Unexpected control characters
   ╭─[no_control_regex.tsx:1:2]
 1 │ /\x1f\0/
   ·  ──┬──┬
   ·    │  ╰── '\0' matches the null character (U+0000), which is a control character.
   ·    ╰── 'U+001F' is a control character.
   ╰────

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 11, 2026
Copy link
Member Author

camchenry commented Jan 11, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 11, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1


Comparing 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans (a7e8cd5) with 01-10-refactor_linter_no-constant-condition_add_label_to_span_and_better_help_text (9281247)

Open in CodSpeed

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry changed the base branch from 01-10-refactor_linter_no-constant-condition_add_label_to_span_and_better_help_text to graphite-base/17861 January 11, 2026 04:05
@camchenry camchenry force-pushed the 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans branch from 510bf23 to 80c14d2 Compare January 11, 2026 04:16
@camchenry camchenry force-pushed the graphite-base/17861 branch from f74562d to 9281247 Compare January 11, 2026 04:16
@camchenry camchenry changed the base branch from graphite-base/17861 to 01-10-refactor_linter_no-constant-condition_add_label_to_span_and_better_help_text January 11, 2026 04:16
@github-actions github-actions bot added the A-cli Area - CLI label Jan 11, 2026
@camchenry camchenry force-pushed the 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans branch from 80c14d2 to a7e8cd5 Compare January 11, 2026 04:41
@camchenry camchenry marked this pull request as ready for review January 11, 2026 04:44
@camchenry camchenry requested a review from camc314 as a code owner January 11, 2026 04:44
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 11, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 11, 2026

Merge activity

…17861)

Moving the help text to the actual spans makes it easier to see what code is actually being referenced.

GitHub doesn't render the `.snap` file since it's detected as binary, so here's a sample of the new output:

```
  ⚠ eslint(no-control-regex): Unexpected control character
   ╭─[no_control_regex.tsx:1:14]
 1 │ var regex = /\x1f/
   ·              ──┬─
   ·                ╰── 'U+001F' is a control character.
   ╰────

  ⚠ eslint(no-control-regex): Unexpected control characters
   ╭─[no_control_regex.tsx:1:2]
 1 │ /\0\1\2/
   ·  ─┬─┬─┬
   ·   │ │ ╰── '\2' is a control character. It looks like a backreference, but there is no corresponding capture group.
   ·   │ ╰── '\1' is a control character. It looks like a backreference, but there is no corresponding capture group.
   ·   ╰── '\0' matches the null character (U+0000), which is a control character.
   ╰────

  ⚠ eslint(no-control-regex): Unexpected control characters
   ╭─[no_control_regex.tsx:1:2]
 1 │ /\x1f\0/
   ·  ──┬──┬
   ·    │  ╰── '\0' matches the null character (U+0000), which is a control character.
   ·    ╰── 'U+001F' is a control character.
   ╰────
```
@graphite-app graphite-app bot force-pushed the 01-10-refactor_linter_no-constant-condition_add_label_to_span_and_better_help_text branch from 9281247 to 6c56c95 Compare January 11, 2026 05:13
@graphite-app graphite-app bot force-pushed the 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans branch from a7e8cd5 to 7365e5c Compare January 11, 2026 05:13
Base automatically changed from 01-10-refactor_linter_no-constant-condition_add_label_to_span_and_better_help_text to main January 11, 2026 05:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 11, 2026
@graphite-app graphite-app bot merged commit 7365e5c into main Jan 11, 2026
22 checks passed
@graphite-app graphite-app bot deleted the 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans branch January 11, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant