Skip to content

fix(tasks/website): Handle nested $refs correctly#17739

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-07-fix_tasks_website_handle_nested_refs_correctly
Jan 7, 2026
Merged

fix(tasks/website): Handle nested $refs correctly#17739
graphite-app[bot] merged 1 commit intomainfrom
01-07-fix_tasks_website_handle_nested_refs_correctly

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Jan 7, 2026

The necessary fixes for #17738

Copilot AI review requested due to automatic review settings January 7, 2026 07:13
@github-actions github-actions bot added the C-bug Category - Bug label Jan 7, 2026
Copy link
Member Author

leaysgur commented Jan 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title fix(tasks/website): Handle nested refs correctly fix(tasks/website): Handle nested $refs correctly Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the handling of nested schema references in the website documentation generator. When a schema contains an anyOf with references ($ref) that themselves contain nested anyOf clauses, the code now flattens these nested structures to properly render all schema variants.

Key changes:

  • Introduced a two-pass approach: first collecting and flattening schemas, then processing them
  • Added logic to detect and flatten nested anyOf structures within resolved references
  • Enhanced type detection to check both validation fields and explicit instance types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaysgur leaysgur force-pushed the 01-07-fix_tasks_website_handle_nested_refs_correctly branch 2 times, most recently from 1902a86 to 5c89e39 Compare January 7, 2026 07:23
@leaysgur leaysgur requested a review from Dunqing January 7, 2026 07:32
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 7, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 7, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-07-fix_tasks_website_handle_nested_refs_correctly branch from 5c89e39 to 9523203 Compare January 7, 2026 08:03
@graphite-app graphite-app bot merged commit 9523203 into main Jan 7, 2026
18 checks passed
@graphite-app graphite-app bot deleted the 01-07-fix_tasks_website_handle_nested_refs_correctly branch January 7, 2026 08:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants