chore(linter): port additional tests from unicorn/prefer-at rule.#17632
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports additional test cases from the upstream eslint-plugin-unicorn prefer-at rule that were not previously included. The tests are dynamically generated in the upstream project and were not picked up by the rulegen logic. Some of the newly added test cases are commented out because they currently fail.
- Added 9 new passing test cases for
checkAllIndexAccess: trueoption - Added 2 new failing test cases that currently pass (tests for
array[1]andarray[array.length - 1]) - Commented out 13 additional failing test cases to be fixed later
- Fixed indentation in existing multi-line test strings to use consistent spacing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_linter/src/rules/unicorn/prefer_at.rs | Added new test cases for checkAllIndexAccess option, including passing tests and failing tests (some commented out); fixed indentation in multi-line test strings |
| crates/oxc_linter/src/snapshots/unicorn_prefer_at.snap | Updated snapshot with new test outputs for the two uncommented failing tests and adjusted line numbers to reflect indentation changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #17632 will not alter performanceComparing Summary
Footnotes
|
camc314
approved these changes
Jan 4, 2026
Contributor
Merge activity
|
…7632) We were missing various tests that are generated dynamically in the upstream tests, unfortunately most of them fail currently. I am unsure if we excluded these test cases intentionally when adding this rule, but I assume not? They don't get picked up by the rulegen logic due to being dynamically generated. See https://github.com/sindresorhus/eslint-plugin-unicorn/blob/8fcae1aa5a3f1f2c6014bf33aeda2f016c0a8d9a/test/prefer-at.js for further context. I copy-pasted these tests over, and then commented out the new ones that failed.
c8016f9 to
431ca00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing various tests that are generated dynamically in the upstream tests, unfortunately most of them fail currently. I am unsure if we excluded these test cases intentionally when adding this rule, but I assume not? They don't get picked up by the rulegen logic due to being dynamically generated.
See https://github.com/sindresorhus/eslint-plugin-unicorn/blob/8fcae1aa5a3f1f2c6014bf33aeda2f016c0a8d9a/test/prefer-at.js for further context.
I copy-pasted these tests over, and then commented out the new ones that failed.