CodSpeed Performance Report

Merging #17199 will not alter performance

_{Comparing linter-enforce-config (1bf26cf) with main (ca65047)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Surprisingly, this didn't cause any new problems in the ecosystem ci...? https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/20404230629

I guess not many of them are configuring rules, admittedly, since they don't have a config file at all.

This is a great start - but lets change our approach of how we implement this slighly?

I think the plan should look something like this:

1. convert from_configuration to return a result

 impl Rule for AccessorPairs {
-    fn from_configuration(value: serde_json::Value) -> Self {
-        serde_json::from_value::<DefaultRuleConfig<AccessorPairs>>(value)
+    fn from_configuration(value: serde_json::Value) -> Result<Self, serde_json::error::Error> {
+        Ok(serde_json::from_value::<DefaultRuleConfig<AccessorPairs>>(value)
             .unwrap_or_default()
-            .into_inner()
+            .into_inner())
     }

(in this first version, we can just always return OK, and unwrap in the caller (here)):

https://github.com/Boshen/oxc/blob/main/crates/oxc_linter/src/config/rules.rs#L107

2. convert a single rule to start returning an actual result, and implement the error handling in the config builder (probably want to store all errors, then propogate them up via the CLI)
3. once we've tested 2, and all looks good, do it for all the other rules

This is a great start - but lets change our approach of how we implement this slighly?

I think the plan should look something like this:

1. convert `from_configuration` to return a result

 impl Rule for AccessorPairs {
-    fn from_configuration(value: serde_json::Value) -> Self {
-        serde_json::from_value::<DefaultRuleConfig<AccessorPairs>>(value)
+    fn from_configuration(value: serde_json::Value) -> Result<Self, serde_json::error::Error> {
+        Ok(serde_json::from_value::<DefaultRuleConfig<AccessorPairs>>(value)
             .unwrap_or_default()
-            .into_inner()
+            .into_inner())
     }

(in this first version, we can just always return OK, and unwrap in the caller (here)):

https://github.com/Boshen/oxc/blob/main/crates/oxc_linter/src/config/rules.rs#L107

2. convert a single rule to start returning an actual result, and implement the error handling in the config builder (probably want to store all errors, then propogate them up via the CLI)

3. once we've tested 2, and all looks good, do it for all the other rules

This makes sense to me, I've opened #17479 to implement the first step.