Skip to content

refactor(linter): add debug assertions for tsgolint config/rule resolution#16343

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution
Dec 1, 2025
Merged

refactor(linter): add debug assertions for tsgolint config/rule resolution#16343
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 1, 2025

No description provided.

This was referenced Dec 1, 2025
Merged
Merged
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 1, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 1, 2025
@camc314 camc314 mentioned this pull request Dec 1, 2025
Merged
@camc314 camc314 self-assigned this Dec 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16343 will not alter performance

Comparing c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution (4b312e6) with c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint (e8f1d00)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint (3b1c4b7) during the generation of this report, so bd52b68 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 5b97afd to e8f1d00 Compare December 1, 2025 14:26
@camc314 camc314 force-pushed the c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution branch from 521d252 to faaadc2 Compare December 1, 2025 14:26
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from e8f1d00 to 94b453e Compare December 1, 2025 15:55
@camc314 camc314 force-pushed the c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution branch 2 times, most recently from d692aa6 to 4b312e6 Compare December 1, 2025 15:57
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 94b453e to 3b1c4b7 Compare December 1, 2025 15:57
@camc314 camc314 marked this pull request as ready for review December 1, 2025 16:03
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 1, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 1, 4:03 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 4:03 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 1, 10:54 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 10:54 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 1, 10:59 PM UTC: Merged by the Graphite merge queue.

@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 3b1c4b7 to 2ab5a55 Compare December 1, 2025 16:04
@camc314 camc314 force-pushed the c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution branch 2 times, most recently from b623b48 to 1ed2251 Compare December 1, 2025 16:05
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 2ab5a55 to 5520be4 Compare December 1, 2025 16:05
@graphite-app graphite-app bot force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 5520be4 to 06371e2 Compare December 1, 2025 16:30
graphite-app bot pushed a commit that referenced this pull request Dec 1, 2025
@camc314
refactor(linter): add debug assertions for tsgolint config/rule resol…
363be50 
…ution (#16343)
@graphite-app graphite-app bot force-pushed the c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution branch from 1ed2251 to 363be50 Compare December 1, 2025 16:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
Base automatically changed from c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint to main December 1, 2025 16:35
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
Copilot AI review requested due to automatic review settings December 1, 2025 22:54
@graphite-app graphite-app bot force-pushed the c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution branch from 363be50 to bab95af Compare December 1, 2025 22:54
Copilot AI reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit bab95af into main Dec 1, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-01-refactor_linter_add_debug_assertions_for_tsgolint_config_rule_resolution branch December 1, 2025 22:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@camc314 camc314 mentioned this pull request Dec 2, 2025
Merged
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@camc314 @taearls
refactor(linter): add debug assertions for tsgolint config/rule resol…
ce90bfa 
…ution (oxc-project#16343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314