Skip to content

test(formatter): add tests for issues that are already resolved#16223

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-28-test_formatter_add_tests_for_issues_that_are_already_resolved
Nov 28, 2025
Merged

test(formatter): add tests for issues that are already resolved#16223
graphite-app[bot] merged 1 commit intomainfrom
11-28-test_formatter_add_tests_for_issues_that_are_already_resolved

Conversation

Copy link
Member Author

Dunqing commented Nov 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 28, 2025
@Dunqing Dunqing marked this pull request as ready for review November 28, 2025 01:53
@Dunqing Dunqing assigned Dunqing and leaysgur and unassigned Dunqing Nov 28, 2025
@Dunqing Dunqing requested a review from leaysgur November 28, 2025 01:59
@Dunqing Dunqing force-pushed the 11-28-test_formatter_add_tests_for_issues_that_are_already_resolved branch from cc5a552 to fdf9ebf Compare November 28, 2025 02:13
@Dunqing Dunqing force-pushed the 11-28-fix_formatter_inconsistent_union_type_output_between_two_runs branch from 74a5d03 to fa5087e Compare November 28, 2025 02:16
@Dunqing Dunqing force-pushed the 11-28-test_formatter_add_tests_for_issues_that_are_already_resolved branch from fdf9ebf to 74a0e33 Compare November 28, 2025 02:16
Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me: mv crates/oxc_formatter/tests/fixtures/js/arrow-function/issue-16178.ts to /ts directory.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2025
Copy link
Member

leaysgur commented Nov 28, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 11-28-fix_formatter_inconsistent_union_type_output_between_two_runs branch from fa5087e to 75fd568 Compare November 28, 2025 02:49
@graphite-app graphite-app bot force-pushed the 11-28-test_formatter_add_tests_for_issues_that_are_already_resolved branch from 74a0e33 to 5c304f0 Compare November 28, 2025 02:50
Base automatically changed from 11-28-fix_formatter_inconsistent_union_type_output_between_two_runs to main November 28, 2025 02:55
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 28, 2025
@graphite-app graphite-app bot merged commit 5c304f0 into main Nov 28, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-28-test_formatter_add_tests_for_issues_that_are_already_resolved branch November 28, 2025 02:56
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

2 participants