feat(linter/plugins): introduce RuleTester#16206
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 30, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
87f7b96 to
0ef5845
Compare
0ef5845 to
7d01b65
Compare
7d01b65 to
46826a5
Compare
1302f61 to
afc5df6
Compare
afc5df6 to
df85032
Compare
6ce2fd7 to
1baf878
Compare
df85032 to
54de704
Compare
be3b9ee to
832983a
Compare
1baf878 to
04e394c
Compare
b644de3 to
75f972d
Compare
832983a to
b15c057
Compare
75f972d to
f0fb3fb
Compare
b15c057 to
d89782f
Compare
6f782ba to
b184e4f
Compare
0660dff to
5b44404
Compare
b184e4f to
1d22ec5
Compare
This was referenced Nov 29, 2025
43d7fef to
96f4c5b
Compare
5b44404 to
da999a6
Compare
da999a6 to
e277430
Compare
96f4c5b to
4318041
Compare
e277430 to
89aa6e0
Compare
4318041 to
eb44265
Compare
8203558 to
cfe6531
Compare
eb44265 to
fa5947d
Compare
fa5947d to
26e3bdd
Compare
cfe6531 to
261bd1b
Compare
261bd1b to
ea8ffb9
Compare
Member
Author
Merge activity
|
Part of #16018. Implement `RuleTester` class for testing rules. Has same API as ESLint's `RuleTester`. A few features not implemented yet: * Fixes are not executed, or checked against provided `output`. * Suggestions are not checked (we don't yet have support for suggestions in JS plugins). * No use of config provided through `RuleTester` class constructor or via `RuleTester.setDefaultConfig`.
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 30, 2025
Store `messageId` in `DiagnosticReport` objects. It's not required for sending to Rust, but it is needed for rule tester (#16206). I think it's fine to add a little code that's redundant in the main runtime, because it only has an overhead when a rule produces diagnostics, which should be an uncommon path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #16018.
Implement
RuleTesterclass for testing rules. Has same API as ESLint'sRuleTester.A few features not implemented yet:
output.RuleTesterclass constructor or viaRuleTester.setDefaultConfig.