test(ast/estree): bump acorn-test262 submodule#16108
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 25, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the acorn-test262 submodule to align its test262 and TypeScript submodule versions with those used in the main repository. This alignment fixes numerous erroneous ESTree conformance test failures in test262 (improving from 77 to 9 mismatches, with 284 additional test cases now included). The update also incorporates the latest TS-ESLint parser which altered the TSImportType AST node shape, resulting in 38 new expected mismatches in TypeScript ESTree tests that will be addressed in PR #16109.
Key Changes
- Bumped
acorn-test262submodule from04357148to21042b08 - Test262 conformance improved dramatically: 44669/44746 (99.83%) → 45021/45030 (99.98%)
- TypeScript conformance temporarily decreased: 9745/9753 (99.92%) → 9707/9753 (99.53%) due to
TSImportTypeshape changes (fixes pending in next PR)
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/coverage/snapshots/estree_typescript.snap | Updated snapshot reflecting 38 new mismatches due to TSImportType shape changes in TS-ESLint parser (all import-type related test cases) |
| tasks/coverage/snapshots/estree_test262.snap | Updated snapshot showing significant test coverage improvement with 68 fewer mismatches and 284 additional tests |
| tasks/coverage/snapshots/estree_acorn_jsx.snap | Updated commit hash reference from 04357148 to 21042b08 |
| .github/scripts/clone-parallel.sh | Updated ACORN_TEST262_SHA from 04357148... to 21042b08... to match new submodule version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Bump `acorn-test262` submodule to latest. It aligns its version of `test262` and `TypeScript` submodules to same versions as used in this repo, which fixes a bunch of erroneous ESTree conformance test failures. It also updates to latest version of TS-ESLint parser, which altered the shape of `TSImportType` (typescript-eslint/typescript-eslint#11591). The test cases broken by this are fixed in next PR (#16109).
ee79f95 to
1d70bab
Compare
leaysgur
pushed a commit
that referenced
this pull request
Nov 26, 2025
Bump `acorn-test262` submodule to latest. It aligns its version of `test262` and `TypeScript` submodules to same versions as used in this repo, which fixes a bunch of erroneous ESTree conformance test failures. It also updates to latest version of TS-ESLint parser, which altered the shape of `TSImportType` (typescript-eslint/typescript-eslint#11591). The test cases broken by this are fixed in next PR (#16109).
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Bump `acorn-test262` submodule to latest. It aligns its version of `test262` and `TypeScript` submodules to same versions as used in this repo, which fixes a bunch of erroneous ESTree conformance test failures. It also updates to latest version of TS-ESLint parser, which altered the shape of `TSImportType` (typescript-eslint/typescript-eslint#11591). The test cases broken by this are fixed in next PR (oxc-project#16109).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
acorn-test262submodule to latest. It aligns its version oftest262andTypeScriptsubmodules to same versions as used in this repo, which fixes a bunch of erroneous ESTree conformance test failures.It also updates to latest version of TS-ESLint parser, which altered the shape of
TSImportType(typescript-eslint/typescript-eslint#11591). The test cases broken by this are fixed in next PR (#16109).