refactor(vscode): move restart & toggle lsp server to linter.ts#16080
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 25, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the VSCode extension by moving linter-specific command registrations (restartServer and toggleEnable) from the main extension file into the linter module itself. This improves code organization by co-locating commands with their implementations.
Key Changes
- Command registrations for
restartServerandtoggleEnablemoved fromextension.tstolinter.ts - Removed
toggleClientandrestartClientfrom theToolInterfaceas they are now only used internally withinLinterTool - Updated command enum ordering to group linter-specific commands together with clarifying comments
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
editors/vscode/client/extension.ts |
Removed restartServer and toggleEnable command registrations from the main extension activation |
editors/vscode/client/tools/linter.ts |
Added restartServer and toggleEnable command registrations within the linter's activate method |
editors/vscode/client/tools/ToolInterface.ts |
Removed toggleClient and restartClient method signatures from the interface |
editors/vscode/client/commands.ts |
Reordered command enum entries and added comment to group linter-specific commands |
editors/vscode/tests/commands.spec.ts |
Updated expected command order in test to match new registration order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
444b911 to
20c1123
Compare
410b208 to
21d8200
Compare
21d8200 to
ca939c5
Compare
20c1123 to
0e636f0
Compare
camc314
approved these changes
Nov 25, 2025
Contributor
Merge activity
|
0e636f0 to
5ccbd9e
Compare
ca939c5 to
5a29274
Compare
5ccbd9e to
4d56147
Compare
5a29274 to
62fb4c4
Compare
Base automatically changed from
11-24-chore_vscode_introduce_oxc.path.oxlint_and_deprecate_oxc.path.server_
to
main
November 25, 2025 11:19
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…c-project#16080) Add separate commands for linter server restart and the future formatter server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add separate commands for linter server restart and the future formatter server.